Auto merge of #17488 - alibektas:17485/duplicate_snippets, r=alibektas

bors · bors · commit a16d63c8b36e · 2024-06-24T11:34:13.000Z
minor : Fix duplicate snippets showing up on hover. With each `config::apply_change` duplicate configs were being added. Now we first drain the vec that holds these and then start adding. This fixes #17485
diff --git a/src/tools/rust-analyzer/crates/rust-analyzer/src/config.rs b/src/tools/rust-analyzer/crates/rust-analyzer/src/config.rs
@@ -844,6 +844,9 @@ impl Config {
             config.source_root_parent_map = source_root_map;
         }
 
+        // IMPORTANT : This holds as long as ` completion_snippets_custom` is declared `client`.
+        config.snippets.clear();
+
         let snips = self.completion_snippets_custom().to_owned();
 
         for (name, def) in snips.iter() {

Original file line number	Diff line number	Diff line change
`@@ -844,6 +844,9 @@ impl Config {`
`844`	`844`	`config.source_root_parent_map = source_root_map;`
`845`	`845`	`}`
`846`	`846`
	`847`	+ // IMPORTANT : This holds as long as ` completion_snippets_custom` is declared `client`.
	`848`	`+ config.snippets.clear();`
	`849`	`+`
`847`	`850`	`let snips = self.completion_snippets_custom().to_owned();`
`848`	`851`
`849`	`852`	`for (name, def) in snips.iter() {`