Skip to content

Commit 97b1d2e

Browse files
committed
Standardize mgca FIXMEs to "mgca"
1 parent 97aa94e commit 97b1d2e

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

compiler/rustc_ast_lowering/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2084,7 +2084,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
20842084
path,
20852085
ParamMode::Optional,
20862086
AllowReturnTypeNotation::No,
2087-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2087+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
20882088
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
20892089
None,
20902090
);
@@ -2159,7 +2159,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
21592159
path,
21602160
ParamMode::Optional,
21612161
AllowReturnTypeNotation::No,
2162-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2162+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
21632163
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
21642164
None,
21652165
);

compiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ fn generic_arg_mismatch_err(
115115
body.value.kind
116116
&& let Res::Def(DefKind::Fn { .. }, id) = path.res
117117
{
118-
// FIXME(min_generic_const_args): this branch is dead once new const path lowering
118+
// FIXME(mgca): this branch is dead once new const path lowering
119119
// (for single-segment paths) is no longer gated
120120
err.help(format!("`{}` is a function item, not a type", tcx.item_name(id)));
121121
err.help("function item types cannot be named directly");

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2233,7 +2233,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22332233
let assoc_ident = assoc_segment.ident;
22342234

22352235
// Check if we have an enum variant or an inherent associated const.
2236-
// FIXME(min_generic_const_args): handle assoc fns once we support those
2236+
// FIXME(mgca): handle assoc fns once we support those
22372237
if let Some(adt_def) = self.probe_adt(span, qself_ty) {
22382238
if adt_def.is_enum() {
22392239
let variant_def = adt_def
@@ -2251,7 +2251,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22512251
}
22522252
}
22532253

2254-
// FIXME(min_generic_const_args): Support self types other than ADTs.
2254+
// FIXME(mgca): Support self types other than ADTs.
22552255
let candidates = tcx
22562256
.inherent_impls(adt_def.did())
22572257
.iter()
@@ -2269,7 +2269,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22692269
match &candidates[..] {
22702270
[] => {}
22712271
&[(impl_, assoc)] => {
2272-
// FIXME(min_generic_const_args): adapted from temporary inherent assoc ty code that may be incorrect
2272+
// FIXME(mgca): adapted from temporary inherent assoc ty code that may be incorrect
22732273
let parent_args = ty::GenericArgs::identity_for_item(tcx, impl_);
22742274
let args = self.lower_generic_args_of_assoc_item(
22752275
span,

compiler/rustc_hir_typeck/src/fn_ctxt/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ impl<'tcx> HirTyLowerer<'tcx> for FnCtxt<'_, 'tcx> {
340340
) -> Const<'tcx> {
341341
let trait_ref = self.instantiate_binder_with_fresh_vars(
342342
span,
343-
// FIXME(min_generic_const_args): this should be assoc const not assoc type
343+
// FIXME(mgca): this should be assoc const not assoc type
344344
infer::BoundRegionConversionTime::AssocTypeProjection(item_def_id),
345345
poly_trait_ref,
346346
);

compiler/rustc_trait_selection/src/traits/select/confirmation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
400400
let predicate = obligation.predicate.skip_binder();
401401

402402
let mut assume = predicate.trait_ref.args.const_at(2);
403-
// FIXME(min_generic_const_exprs): We should shallowly normalize this.
403+
// FIXME(mgca): We should shallowly normalize this.
404404
if self.tcx().features().generic_const_exprs() {
405405
assume = crate::traits::evaluate_const(self.infcx, assume, obligation.param_env)
406406
}

0 commit comments

Comments
 (0)