review

Author: klensy

compiler/rustc_codegen_ssa/src/back/metadata.rs

@@ -408,7 +408,7 @@ pub(crate) fn create_object_file(sess: &Session) -> Option<write::Object<'static
 /// Mach-O files contain information about:
 /// - The platform/OS they were built for (macOS/watchOS/Mac Catalyst/iOS simulator etc).
 /// - The minimum OS version / deployment target.
-/// - The version of the SDK they were targeting.
+/// - The version of the SDK they were targetting.
 ///
 /// In the past, this was accomplished using the LC_VERSION_MIN_MACOSX, LC_VERSION_MIN_IPHONEOS,
 /// LC_VERSION_MIN_TVOS or LC_VERSION_MIN_WATCHOS load commands, which each contain information

compiler/rustc_errors/src/tests.rs

@@ -97,7 +97,7 @@ fn wellformed_fluent() {
 }
 
 #[test]
-fn malformed_fluent() {
+fn misformed_fluent() {
     let dummy = make_dummy("mir_build_borrow_of_moved_value = borrow of moved value
     .label = value moved into `{name}` here
     .occurs_because_label = move occurs because `{$oops}` has type `{$ty}` which does not implement the `Copy` trait

compiler/rustc_lint_defs/src/builtin.rs

@@ -4435,7 +4435,7 @@ declare_lint! {
 
 declare_lint! {
     /// The `refining_impl_trait_reachable` lint detects `impl Trait` return
-    /// types in method signatures that are refined by a publicly reachable
+    /// types in method signatures that are refined by a publically reachable
     /// trait implementation, meaning the implementation adds information about
     /// the return type that is not present in the trait.
     ///

library/std/src/sys_common/mod.rs

@@ -54,17 +54,17 @@ pub trait FromInner<Inner> {
     fn from_inner(inner: Inner) -> Self;
 }
 
-// Computes (value*numerator)/denom without overflow, as long as both
-// (numerator*denom) and the overall result fit into i64 (which is the case
+// Computes (value*numer)/denom without overflow, as long as both
+// (numer*denom) and the overall result fit into i64 (which is the case
 // for our time conversions).
 #[allow(dead_code)] // not used on all platforms
-pub fn mul_div_u64(value: u64, numerator: u64, denom: u64) -> u64 {
+pub fn mul_div_u64(value: u64, numer: u64, denom: u64) -> u64 {
     let q = value / denom;
     let r = value % denom;
     // Decompose value as (value/denom*denom + value%denom),
-    // substitute into (value*numerator)/denom and simplify.
-    // r < denom, so (denom*numerator) is the upper bound of (r*numerator)
-    q * numerator + r * numerator / denom
+    // substitute into (value*numer)/denom and simplify.
+    // r < denom, so (denom*numer) is the upper bound of (r*numer)
+    q * numer + r * numer / denom
 }
 
 pub fn ignore_notfound<T>(result: crate::io::Result<T>) -> crate::io::Result<()> {

src/tools/tidy/src/ext_tool_checks.rs

@@ -219,18 +219,17 @@ fn check_impl(
 
     if spellcheck_all || spellcheck_fix {
         let config_path = root_path.join("typos.toml");
-        let mut args =
         // sync target files with .github/workflows/ci.yml
+        let mut args =
             vec!["-c", config_path.as_os_str().to_str().unwrap(), "./compiler", "./library"];
 
         if spellcheck_all {
             eprintln!("spellcheck files");
-            spellcheck_runner(&args)?;
         } else if spellcheck_fix {
             eprintln!("spellcheck files and fix");
             args.push("--write-changes");
-            spellcheck_runner(&args)?;
         }
+        spellcheck_runner(&args)?;
     }
 
     Ok(())

typos.toml

@@ -34,8 +34,18 @@ matcheable = "matcheable"
 smove = "smove"
 childs = "childs"
 filetimes = "filetimes"
+misformed = "misformed"
+targetting = "targetting"
+publically = "publically"
 
 [default.extend-identifiers]
+# Entries goes here if typo is part of some existing ident
+# where you want to keep it, but don't want to allow
+# such typos everywhere.
+#
+# I.e. you don't want (or can't) fix some constant name, like
+# `DNS_ERROR_INVAILD_VIRTUALIZATION_INSTANCE_NAME` but actually
+# want to see `INVAILD` typo fixed in other places.
 ERROR_FILENAME_EXCED_RANGE = "ERROR_FILENAME_EXCED_RANGE"
 DNS_ERROR_INVAILD_VIRTUALIZATION_INSTANCE_NAME = "DNS_ERROR_INVAILD_VIRTUALIZATION_INSTANCE_NAME"
 ERROR_DS_FILTER_USES_CONTRUCTED_ATTRS = "ERROR_DS_FILTER_USES_CONTRUCTED_ATTRS"
@@ -44,6 +54,7 @@ ERROR_MCA_OCCURED = "ERROR_MCA_OCCURED"
 ERRNO_ACCES = "ERRNO_ACCES"
 tolen = "tolen"
 pard = "pard"
+numer = "numer"
 
 [default]
 extend-ignore-words-re = [