Skip to content

Commit 6ce6194

Browse files
committed
Standardize mgca FIXMEs to "mgca"
1 parent 682a63c commit 6ce6194

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

compiler/rustc_ast_lowering/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2073,7 +2073,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
20732073
path,
20742074
ParamMode::Optional,
20752075
AllowReturnTypeNotation::No,
2076-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2076+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
20772077
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
20782078
None,
20792079
);
@@ -2148,7 +2148,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
21482148
path,
21492149
ParamMode::Optional,
21502150
AllowReturnTypeNotation::No,
2151-
// FIXME(min_generic_const_args): update for `fn foo() -> Bar<FOO<impl Trait>>` support
2151+
// FIXME(mgca): update for `fn foo() -> Bar<FOO<impl Trait>>` support
21522152
ImplTraitContext::Disallowed(ImplTraitPosition::Path),
21532153
None,
21542154
);

compiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ fn generic_arg_mismatch_err(
115115
body.value.kind
116116
&& let Res::Def(DefKind::Fn { .. }, id) = path.res
117117
{
118-
// FIXME(min_generic_const_args): this branch is dead once new const path lowering
118+
// FIXME(mgca): this branch is dead once new const path lowering
119119
// (for single-segment paths) is no longer gated
120120
err.help(format!("`{}` is a function item, not a type", tcx.item_name(id)));
121121
err.help("function item types cannot be named directly");

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2294,7 +2294,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
22942294
let assoc_ident = assoc_segment.ident;
22952295

22962296
// Check if we have an enum variant or an inherent associated const.
2297-
// FIXME(min_generic_const_args): handle assoc fns once we support those
2297+
// FIXME(mgca): handle assoc fns once we support those
22982298
if let Some(adt_def) = self.probe_adt(span, qself_ty) {
22992299
if adt_def.is_enum() {
23002300
let variant_def = adt_def
@@ -2312,7 +2312,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
23122312
}
23132313
}
23142314

2315-
// FIXME(min_generic_const_args): Support self types other than ADTs.
2315+
// FIXME(mgca): Support self types other than ADTs.
23162316
let candidates = tcx
23172317
.inherent_impls(adt_def.did())
23182318
.iter()
@@ -2330,7 +2330,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
23302330
match &candidates[..] {
23312331
[] => {}
23322332
&[(impl_, assoc)] => {
2333-
// FIXME(min_generic_const_args): adapted from temporary inherent assoc ty code that may be incorrect
2333+
// FIXME(mgca): adapted from temporary inherent assoc ty code that may be incorrect
23342334
let parent_args = ty::GenericArgs::identity_for_item(tcx, impl_);
23352335
let args = self.lower_generic_args_of_assoc_item(
23362336
span,

compiler/rustc_hir_typeck/src/fn_ctxt/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ impl<'tcx> HirTyLowerer<'tcx> for FnCtxt<'_, 'tcx> {
340340
) -> Const<'tcx> {
341341
let trait_ref = self.instantiate_binder_with_fresh_vars(
342342
span,
343-
// FIXME(min_generic_const_args): this should be assoc const not assoc type
343+
// FIXME(mgca): this should be assoc const not assoc type
344344
infer::BoundRegionConversionTime::AssocTypeProjection(item_def_id),
345345
poly_trait_ref,
346346
);

compiler/rustc_trait_selection/src/traits/select/confirmation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
410410
let predicate = obligation.predicate.skip_binder();
411411

412412
let mut assume = predicate.trait_ref.args.const_at(2);
413-
// FIXME(min_generic_const_exprs): We should shallowly normalize this.
413+
// FIXME(mgca): We should shallowly normalize this.
414414
if self.tcx().features().generic_const_exprs() {
415415
assume = crate::traits::evaluate_const(self.infcx, assume, obligation.param_env)
416416
}

0 commit comments

Comments
 (0)