Skip to content

Commit 5db6907

Browse files
committed
review
1 parent 4c75b32 commit 5db6907

21 files changed

+42
-42
lines changed

compiler/rustc_ast/src/ast.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ impl fmt::Display for ParamKindOrd {
333333
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
334334
match self {
335335
ParamKindOrd::Lifetime => "lifetime".fmt(f),
336-
ParamKindOrd::TypeOrConst => "type or const".fmt(f),
336+
ParamKindOrd::TypeOrConst => "type and const".fmt(f),
337337
}
338338
}
339339
}

src/test/ui/const-generics/argument_order.stderr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: lifetime parameters must be declared prior to type or const parameters
1+
error: lifetime parameters must be declared prior to type and const parameters
22
--> $DIR/argument_order.rs:6:32
33
|
44
LL | struct AlsoBad<const N: usize, 'a, T, 'b, const M: usize, U> {
@@ -11,7 +11,7 @@ LL | let _: AlsoBad<7, 'static, u32, 'static, 17, u16>;
1111
| ^^^^^^^
1212
|
1313
= note: lifetime arguments must be provided before type arguments
14-
= help: reorder the arguments: lifetimes, then type or consts: `<'a, 'b, N, T, M, U>`
14+
= help: reorder the arguments: lifetimes, then type and consts: `<'a, 'b, N, T, M, U>`
1515

1616
error: aborting due to 2 previous errors
1717

src/test/ui/const-generics/const-param-before-other-params.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
fn bar<const X: u8, 'a>(_: &'a ()) {
2-
//~^ ERROR lifetime parameters must be declared prior to type or const parameters
2+
//~^ ERROR lifetime parameters must be declared prior to type and const parameters
33
}
44

55
fn foo<const X: u8, T>(_: &T) {}

src/test/ui/const-generics/const-param-before-other-params.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: lifetime parameters must be declared prior to type or const parameters
1+
error: lifetime parameters must be declared prior to type and const parameters
22
--> $DIR/const-param-before-other-params.rs:1:21
33
|
44
LL | fn bar<const X: u8, 'a>(_: &'a ()) {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
// Checks that lifetimes cannot be interspersed between consts and types.
22

33
struct Foo<const N: usize, 'a, T = u32>(&'a (), T);
4-
//~^ ERROR lifetime parameters must be declared prior to type or const parameters
4+
//~^ ERROR lifetime parameters must be declared prior to type and const parameters
55

66
struct Bar<const N: usize, T = u32, 'a>(&'a (), T);
7-
//~^ ERROR lifetime parameters must be declared prior to type or const parameters
7+
//~^ ERROR lifetime parameters must be declared prior to type and const parameters
88

99
fn main() {}

src/test/ui/const-generics/defaults/intermixed-lifetime.stderr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
error: lifetime parameters must be declared prior to type or const parameters
1+
error: lifetime parameters must be declared prior to type and const parameters
22
--> $DIR/intermixed-lifetime.rs:3:28
33
|
44
LL | struct Foo<const N: usize, 'a, T = u32>(&'a (), T);
55
| -----------------^^---------- help: reorder the parameters: lifetimes, then consts and types: `<'a, const N: usize, T = u32>`
66

7-
error: lifetime parameters must be declared prior to type or const parameters
7+
error: lifetime parameters must be declared prior to type and const parameters
88
--> $DIR/intermixed-lifetime.rs:6:37
99
|
1010
LL | struct Bar<const N: usize, T = u32, 'a>(&'a (), T);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
struct Foo<const M: usize = 10, 'a>(&'a u32);
2-
//~^ ERROR lifetime parameters must be declared prior to type or const parameters
2+
//~^ ERROR lifetime parameters must be declared prior to type and const parameters
33

44
fn main() {}

src/test/ui/const-generics/defaults/param-order-err-pretty-prints-default.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: lifetime parameters must be declared prior to type or const parameters
1+
error: lifetime parameters must be declared prior to type and const parameters
22
--> $DIR/param-order-err-pretty-prints-default.rs:1:33
33
|
44
LL | struct Foo<const M: usize = 10, 'a>(&'a u32);

src/test/ui/generics/issue-59508-1.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ struct A;
88

99
impl A {
1010
pub fn do_things<T, 'a, 'b: 'a>() {
11-
//~^ ERROR lifetime parameters must be declared prior to type or const parameters
11+
//~^ ERROR lifetime parameters must be declared prior to type and const parameters
1212
println!("panic");
1313
}
1414
}

src/test/ui/generics/issue-59508-1.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
error: lifetime parameters must be declared prior to type or const parameters
1+
error: lifetime parameters must be declared prior to type and const parameters
22
--> $DIR/issue-59508-1.rs:10:25
33
|
44
LL | pub fn do_things<T, 'a, 'b: 'a>() {

0 commit comments

Comments
 (0)