Skip to content

Commit 4bdd671

Browse files
committed
Update run-make test
1 parent db0b491 commit 4bdd671

File tree

5 files changed

+25
-4
lines changed

5 files changed

+25
-4
lines changed

tests/run-make/linker-warning/bar.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#[repr(C)]
2+
pub struct Bar(u32);

tests/run-make/linker-warning/foo.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#[repr(C)]
2+
pub struct Foo(u32);

tests/run-make/linker-warning/main.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,10 @@
1-
fn main() {}
1+
unsafe extern "C" {
2+
#[cfg(only_foo)]
3+
fn does_not_exist(p: *const u8) -> *const foo::Foo;
4+
#[cfg(not(only_foo))]
5+
fn does_not_exist(p: *const bar::Bar) -> *const foo::Foo;
6+
}
7+
8+
fn main() {
9+
let _ = unsafe { does_not_exist(core::ptr::null()) };
10+
}

tests/run-make/linker-warning/rmake.rs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ fn run_rustc() -> Rustc {
1111
.arg("-Clink-self-contained=-linker")
1212
.arg("-Zunstable-options")
1313
.arg("-Wlinker-messages")
14+
.args(["--extern", "foo", "--extern", "bar"])
1415
.output("main")
1516
.linker("./fake-linker");
1617
if run_make_support::target() == "x86_64-unknown-linux-gnu" {
@@ -21,8 +22,10 @@ fn run_rustc() -> Rustc {
2122
}
2223

2324
fn main() {
24-
// first, compile our linker
25+
// first, compile our linker and our dependencies
2526
rustc().arg("fake-linker.rs").output("fake-linker").run();
27+
rustc().arg("foo.rs").crate_type("rlib").run();
28+
rustc().arg("bar.rs").crate_type("rlib").run();
2629

2730
// Run rustc with our fake linker, and make sure it shows warnings
2831
let warnings = run_rustc().link_arg("run_make_warn").run();
@@ -48,7 +51,8 @@ fn main() {
4851
let out = run_rustc().link_arg("run_make_error").run_fail();
4952
out.assert_stderr_contains("fake-linker")
5053
.assert_stderr_contains("object files omitted")
51-
.assert_stderr_contains_regex(r"\{")
54+
.assert_stderr_contains("/{libfoo,libbar}.rlib\"")
55+
.assert_stderr_contains("-*}.rlib\"")
5256
.assert_stderr_not_contains(r".rcgu.o")
5357
.assert_stderr_not_contains_regex(r"lib(/|\\\\)libstd");
5458

@@ -68,6 +72,10 @@ fn main() {
6872
.run();
6973
}
7074

75+
// Make sure a single dependency doesn't use brace expansion.
76+
let out1 = run_rustc().cfg("only_foo").link_arg("run_make_error").run_fail();
77+
out1.assert_stderr_contains("fake-linker").assert_stderr_contains("/libfoo.rlib\"");
78+
7179
// Make sure we show linker warnings even across `-Z no-link`
7280
rustc()
7381
.arg("-Zno-link")

tests/run-make/linker-warning/short-error.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
error: linking with `./fake-linker` failed: exit status: 1
22
|
3-
= note: "./fake-linker" "-m64" "/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,libcfg_if-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/build-root/test/run-make/linker-warning/rmake_out" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "run_make_error"
3+
= note: "./fake-linker" "-m64" "/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/build-root/test/run-make/linker-warning/rmake_out/{libfoo,libbar}.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,libcfg_if-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/build-root/test/run-make/linker-warning/rmake_out" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "run_make_error"
44
= note: some arguments are omitted. use `--verbose` to show all linker arguments
55
= note: error: baz
66

0 commit comments

Comments
 (0)