Port issue-11908 to rmake

Author: Oneirical

src/tools/run-make-support/src/lib.rs

@@ -82,11 +82,43 @@ pub fn static_lib_name(name: &str) -> String {
     //     endif
     // endif
     // ```
-    assert!(!name.contains(char::is_whitespace), "name cannot contain whitespace");
+    assert!(!name.contains(char::is_whitespace), "static library name cannot contain whitespace");
 
     if target().contains("msvc") { format!("{name}.lib") } else { format!("lib{name}.a") }
 }
 
+/// Construct a path to a dynamic library under `$TMPDIR` given the library name. This will return a
+/// path with `$TMPDIR` joined with platform-and-compiler-specific library name.
+pub fn dynamic_lib(name: &str) -> PathBuf {
+    tmp_dir().join(dynamic_lib_name(name))
+}
+
+/// Construct the dynamic library name based on the platform.
+pub fn dynamic_lib_name(name: &str) -> String {
+    // See tools.mk (irrelevant lines omitted):
+    //
+    // ```makefile
+    // ifeq ($(UNAME),Darwin)
+    //     DYLIB = $(TMPDIR)/lib$(1).dylib
+    // else
+    //     ifdef IS_WINDOWS
+    //         DYLIB = $(TMPDIR)/$(1).dll
+    //     else
+    //         DYLIB = $(TMPDIR)/lib$(1).so
+    //     endif
+    // endif
+    // ```
+    assert!(!name.contains(char::is_whitespace), "dynamic library name cannot contain whitespace");
+
+    if target().contains("darwin") {
+        format!("lib{name}.dylib")
+    } else if target().contains("windows") {
+        format!("{name}.dll")
+    } else {
+        format!("lib{name}.so")
+    }
+}
+
 /// Construct the binary name based on platform.
 pub fn bin_name(name: &str) -> String {
     if is_windows() { format!("{name}.exe") } else { name.to_string() }

src/tools/run-make-support/src/rustc.rs

@@ -150,12 +150,6 @@ impl Rustc {
         self
     }
 
-    /// Enables link time optimizations in rustc. Equivalent to `-Clto``.
-    pub fn lto(&mut self) -> &mut Self {
-        self.cmd.arg("-Clto");
-        self
-    }
-
     /// Add a directory to the library search path.
     pub fn library_search_path<P: AsRef<Path>>(&mut self, path: P) -> &mut Self {
         self.cmd.arg("-L");

src/tools/tidy/src/allowed_run_make_makefiles.txt

@@ -94,7 +94,6 @@ run-make/invalid-staticlib/Makefile
 run-make/issue-107094/Makefile
 run-make/issue-10971-temps-dir/Makefile
 run-make/issue-109934-lto-debuginfo/Makefile
-run-make/issue-11908/Makefile
 run-make/issue-14698/Makefile
 run-make/issue-15460/Makefile
 run-make/issue-18943/Makefile

tests/run-make/issue-11908/Makefile

@@ -0,0 +1,49 @@
+// A path which contains the same rlib or dylib in two locations
+// should not cause an assertion panic in the compiler.
+// This test tries to replicate the linked issue and checks
+// if the bugged error makes a resurgence.
+
+// Note that this relies on `liburl` to be in the path somewhere else.
+// Our aux-built libraries will collide with liburl (they have
+// the same version listed)
+
+// See https://github.com/rust-lang/rust/issues/11908
+
+//@ ignore-cross-compile
+
+use run_make_support::{rustc, dynamic_lib, tmp_dir};
+use std::fs;
+
+fn main() {
+    let mut tmp_dir_other = tmp_dir();
+    tmp_dir_other.push("other");
+
+    fs::create_dir(tmp_dir_other);
+    rustc().input("foo.rs")
+        .crate_type("dylib")
+        .codegen_option("prefer-dynamic")
+        .run();
+    fs::rename(dynamic_lib("foo"), tmp_dir_other);
+    rustc().input("foo.rs")
+        .crate_type("dylib")
+        .codegen_option("prefer-dynamic")
+        .run();
+    rustc().input("bar.rs")
+        .library_search_path(tmp_dir_other)
+        .run();
+    fs::remove_dir_all(tmp_dir());
+
+    fs::create_dir_all(tmp_dir_other);
+    rustc().input("foo.rs")
+        .crate_type("rlib")
+        .run();
+    let mut tmp_dir_libfoo = tmp_dir();
+    tmp_dir_libfoo.push("libfoo.rlib");
+    fs::rename(tmp_dir_libfoo, tmp_dir_other);
+    rustc().input("foo.rs")
+        .crate_type("rlib")
+        .run();
+    rustc().input("bar.rs")
+        .library_search_path(tmp_dir_other)
+        .run();
+}