rustc: make util::ppaux private.

Author: eddyb

src/librustc/infer/error_reporting/mod.rs

@@ -760,7 +760,7 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
     }
 
     /// For generic types with parameters with defaults, remove the parameters corresponding to
-    /// the defaults. This repeats a lot of the logic found in `PrintCx::parameterized`.
+    /// the defaults. This repeats a lot of the logic found in `ty::print::pretty`.
     fn strip_generic_default_params(
         &self,
         def_id: DefId,

src/librustc/lib.rs

@@ -154,7 +154,7 @@ pub mod ty;
 pub mod util {
     pub mod captures;
     pub mod common;
-    pub mod ppaux;
+    mod ppaux;
     pub mod nodemap;
     pub mod time_graph;
     pub mod profiling;

src/librustc/mir/mod.rs

@@ -33,7 +33,7 @@ use ty::{
     self, AdtDef, CanonicalUserTypeAnnotations, ClosureSubsts, GeneratorSubsts, Region, Ty, TyCtxt,
     UserTypeAnnotationIndex,
 };
-use util::ppaux;
+use ty::print::{FmtPrinter, Printer, PrintCx};
 
 pub use mir::interpret::AssertMessage;
 
@@ -2378,7 +2378,12 @@ impl<'tcx> Debug for Rvalue<'tcx> {
                     AggregateKind::Adt(adt_def, variant, substs, _user_ty, _) => {
                         let variant_def = &adt_def.variants[variant];
 
-                        ppaux::parameterized(fmt, variant_def.did, substs, Namespace::ValueNS)?;
+                        let f = &mut *fmt;
+                        PrintCx::with_tls_tcx(FmtPrinter::new(f, Namespace::ValueNS), |cx| {
+                            let substs = cx.tcx.lift(&substs).expect("could not lift for printing");
+                            cx.print_def_path(variant_def.did, Some(substs), iter::empty())?;
+                            Ok(())
+                        })?;
 
                         match variant_def.ctor_kind {
                             CtorKind::Const => Ok(()),

src/librustc/traits/structural_impls.rs

@@ -165,7 +165,8 @@ impl<'tcx> fmt::Display for traits::WhereClause<'tcx> {
     fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
         use traits::WhereClause::*;
 
-        // Bypass ppaux because it does not print out anonymous regions.
+        // Bypass `ty::print` because it does not print out anonymous regions.
+        // FIXME(eddyb) implement a custom `PrettyPrinter`, or move this to `ty::print`.
         fn write_region_name<'tcx>(
             r: ty::Region<'tcx>,
             fmt: &mut fmt::Formatter<'_>
@@ -256,7 +257,7 @@ impl fmt::Display for traits::QuantifierKind {
 }
 
 /// Collect names for regions / types bound by a quantified goal / clause.
-/// This collector does not try to do anything clever like in ppaux, it's just used
+/// This collector does not try to do anything clever like in `ty::print`, it's just used
 /// for debug output in tests anyway.
 struct BoundNamesCollector {
     // Just sort by name because `BoundRegion::BrNamed` does not have a `BoundVar` index anyway.

src/librustc/ty/instance.rs

@@ -2,9 +2,9 @@ use hir::Unsafety;
 use hir::def::Namespace;
 use hir::def_id::DefId;
 use ty::{self, Ty, PolyFnSig, TypeFoldable, Substs, TyCtxt};
+use ty::print::{FmtPrinter, Printer, PrintCx};
 use traits;
 use rustc_target::spec::abi::Abi;
-use util::ppaux;
 
 use std::fmt;
 use std::iter;
@@ -175,7 +175,12 @@ impl<'tcx> InstanceDef<'tcx> {
 
 impl<'tcx> fmt::Display for Instance<'tcx> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        ppaux::parameterized(f, self.def_id(), self.substs, Namespace::ValueNS)?;
+        PrintCx::with_tls_tcx(FmtPrinter::new(&mut *f, Namespace::ValueNS), |cx| {
+            let substs = cx.tcx.lift(&self.substs).expect("could not lift for printing");
+            cx.print_def_path(self.def_id(), Some(substs), iter::empty())?;
+            Ok(())
+        })?;
+
         match self.def {
             InstanceDef::Item(_) => Ok(()),
             InstanceDef::VtableShim(_) => {

src/librustc/util/ppaux.rs

@@ -1,7 +1,6 @@
 use hir;
 use hir::def::Namespace;
-use hir::def_id::DefId;
-use ty::subst::{Kind, Substs, UnpackedKind};
+use ty::subst::{Kind, UnpackedKind};
 use ty::{self, Ty};
 use ty::print::{FmtPrinter, PrettyPrinter, PrintCx, Print, Printer};
 
@@ -141,19 +140,6 @@ macro_rules! define_scoped_cx {
     };
 }
 
-pub fn parameterized<F: fmt::Write>(
-    f: &mut F,
-    did: DefId,
-    substs: &Substs<'_>,
-    ns: Namespace,
-) -> fmt::Result {
-    PrintCx::with_tls_tcx(FmtPrinter::new(f, ns), |cx| {
-        let substs = cx.tcx.lift(&substs).expect("could not lift for printing");
-        cx.print_def_path(did, Some(substs), iter::empty())?;
-        Ok(())
-    })
-}
-
 define_print! {
     ('tcx) &'tcx ty::List<ty::ExistentialPredicate<'tcx>>, (self, cx) {
         display {

src/librustc_mir/monomorphize/item.rs

@@ -215,9 +215,8 @@ impl<'a, 'tcx> MonoItemExt<'a, 'tcx> for MonoItem<'tcx> {
 // These keys are used by the handwritten auto-tests, so they need to be
 // predictable and human-readable.
 //
-// Note: A lot of this could looks very similar to what's already in the
-//       ppaux module. It would be good to refactor things so we only have one
-//       parameterizable implementation for printing types.
+// Note: A lot of this could looks very similar to what's already in `ty::print`.
+// FIXME(eddyb) implement a custom `PrettyPrinter` for this.
 
 /// Same as `unique_type_name()` but with the result pushed onto the given
 /// `output` parameter.