Skip to content

Commit 1eff043

Browse files
committed
rustc_codegen_llvm: Remove reference to non-existing no_landing_pads()
Removing this reference was forgotten in eb4725f. Grepping for no_landing_pads returns no hits after this.
1 parent 0d11be5 commit 1eff043

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

compiler/rustc_codegen_llvm/src/attributes.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -377,12 +377,11 @@ pub(crate) fn llfn_attrs_from_instance<'ll, 'tcx>(
377377
// that no exceptions passes by it. This is normally the case for the
378378
// ELF x86-64 abi, but it can be disabled for some compilation units.
379379
//
380-
// Typically when we're compiling with `-C panic=abort` (which implies this
381-
// `no_landing_pads` check) we don't need `uwtable` because we can't
382-
// generate any exceptions! On Windows, however, exceptions include other
383-
// events such as illegal instructions, segfaults, etc. This means that on
384-
// Windows we end up still needing the `uwtable` attribute even if the `-C
385-
// panic=abort` flag is passed.
380+
// Typically when we're compiling with `-C panic=abort` we don't need
381+
// `uwtable` because we can't generate any exceptions! On Windows, however,
382+
// exceptions include other events such as illegal instructions, segfaults,
383+
// etc. This means that on Windows we end up still needing the `uwtable`
384+
// attribute even if the `-C panic=abort` flag is passed.
386385
//
387386
// You can also find more info on why Windows always requires uwtables here:
388387
// https://bugzilla.mozilla.org/show_bug.cgi?id=1302078

0 commit comments

Comments
 (0)