Skip to content

Commit 1b3c370

Browse files
committed
Replace unnecessary use of MacroDefId with MacroId
1 parent 0d5fde2 commit 1b3c370

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/tools/rust-analyzer/crates/hir-def/src/nameres.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ use std::ops::Deref;
6262

6363
use base_db::Crate;
6464
use hir_expand::{
65-
EditionedFileId, ErasedAstId, HirFileId, InFile, MacroCallId, MacroDefId, mod_path::ModPath,
66-
name::Name, proc_macro::ProcMacroKind,
65+
EditionedFileId, ErasedAstId, HirFileId, InFile, MacroCallId, mod_path::ModPath, name::Name,
66+
proc_macro::ProcMacroKind,
6767
};
6868
use intern::Symbol;
6969
use itertools::Itertools;
@@ -189,7 +189,7 @@ pub struct DefMap {
189189
#[derive(Clone, Debug, PartialEq, Eq)]
190190
struct DefMapCrateData {
191191
/// Side table for resolving derive helpers.
192-
exported_derives: FxHashMap<MacroDefId, Box<[Name]>>,
192+
exported_derives: FxHashMap<MacroId, Box<[Name]>>,
193193
fn_proc_macro_mapping: FxHashMap<FunctionId, ProcMacroId>,
194194

195195
/// Custom attributes registered with `#![register_attr]`.

src/tools/rust-analyzer/crates/hir-def/src/nameres/collector.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ impl<'db> DefCollector<'db> {
609609
self.define_proc_macro(def.name.clone(), proc_macro_id);
610610
let crate_data = Arc::get_mut(&mut self.def_map.data).unwrap();
611611
if let ProcMacroKind::Derive { helpers } = def.kind {
612-
crate_data.exported_derives.insert(self.db.macro_def(proc_macro_id.into()), helpers);
612+
crate_data.exported_derives.insert(proc_macro_id.into(), helpers);
613613
}
614614
crate_data.fn_proc_macro_mapping.insert(fn_id, proc_macro_id);
615615
}
@@ -1345,7 +1345,7 @@ impl<'db> DefCollector<'db> {
13451345
// Record its helper attributes.
13461346
if def_id.krate != self.def_map.krate {
13471347
let def_map = crate_def_map(self.db, def_id.krate);
1348-
if let Some(helpers) = def_map.data.exported_derives.get(&def_id) {
1348+
if let Some(helpers) = def_map.data.exported_derives.get(&macro_id) {
13491349
self.def_map
13501350
.derive_helpers_in_scope
13511351
.entry(ast_id.ast_id.map(|it| it.upcast()))
@@ -2425,7 +2425,7 @@ impl ModCollector<'_, '_> {
24252425
Arc::get_mut(&mut self.def_collector.def_map.data)
24262426
.unwrap()
24272427
.exported_derives
2428-
.insert(self.def_collector.db.macro_def(macro_id.into()), helpers);
2428+
.insert(macro_id.into(), helpers);
24292429
}
24302430
}
24312431
}

0 commit comments

Comments
 (0)