Skip to content

Commit 092bc2b

Browse files
committed
Provide a default provide* implementation for CodegenBackend
Both cg_llvm and cg_clif don't override it. cg_spirv does override it, so it needs to be preserved.
1 parent c4c2ab5 commit 092bc2b

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

compiler/rustc_codegen_cranelift/src/lib.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ use rustc_codegen_ssa::CodegenResults;
2929
use rustc_errors::ErrorReported;
3030
use rustc_middle::dep_graph::{WorkProduct, WorkProductId};
3131
use rustc_middle::middle::cstore::{EncodedMetadata, MetadataLoader};
32-
use rustc_middle::ty::query::Providers;
3332
use rustc_session::config::OutputFilenames;
3433
use rustc_session::Session;
3534

@@ -168,9 +167,6 @@ impl CodegenBackend for CraneliftCodegenBackend {
168167
Box::new(rustc_codegen_ssa::back::metadata::DefaultMetadataLoader)
169168
}
170169

171-
fn provide(&self, _providers: &mut Providers) {}
172-
fn provide_extern(&self, _providers: &mut Providers) {}
173-
174170
fn target_features(&self, _sess: &Session) -> Vec<rustc_span::Symbol> {
175171
vec![]
176172
}

compiler/rustc_codegen_llvm/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,6 @@ impl CodegenBackend for LlvmCodegenBackend {
252252
Box::new(rustc_codegen_ssa::back::metadata::DefaultMetadataLoader)
253253
}
254254

255-
fn provide(&self, _providers: &mut ty::query::Providers) {}
256-
fn provide_extern(&self, _providers: &mut ty::query::Providers) {}
257-
258255
fn codegen_crate<'tcx>(
259256
&self,
260257
tcx: TyCtxt<'tcx>,

compiler/rustc_codegen_ssa/src/traits/backend.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ pub trait CodegenBackend {
6464
}
6565

6666
fn metadata_loader(&self) -> Box<MetadataLoaderDyn>;
67-
fn provide(&self, _providers: &mut Providers);
68-
fn provide_extern(&self, _providers: &mut Providers);
67+
fn provide(&self, _providers: &mut Providers) {}
68+
fn provide_extern(&self, _providers: &mut Providers) {}
6969
fn codegen_crate<'tcx>(
7070
&self,
7171
tcx: TyCtxt<'tcx>,

0 commit comments

Comments
 (0)