Migrate remaining clippy lints to regular tool lints

Author: Xanewok

src/lib.rs

@@ -3,6 +3,7 @@
 #![allow(clippy::single_match_else)]
 #![allow(clippy::too_many_lines)]
 #![deny(warnings)]
+
 extern crate rustc_ast;
 extern crate rustc_hir;
 extern crate rustc_infer;

src/mapping.rs

@@ -66,7 +66,7 @@ pub type InherentImplSet = BTreeSet<(DefId, DefId)>;
 /// Definitions and simple `DefId` mappings are kept separate to record both kinds of
 /// correspondence losslessly. The *access* to the stored data happens through the same API,
 /// however. A reverse mapping is also included, but only for `DefId` lookup.
-#[cfg_attr(feature = "cargo-clippy", allow(clippy::module_name_repetitions))]
+#[allow(clippy::module_name_repetitions)]
 pub struct IdMapping {
     /// The old crate.
     old_crate: CrateNum,
@@ -337,7 +337,7 @@ type OptionalExport = Option<Export<HirId>>;
 ///
 /// Both old and new exports can be missing. Allows for reuse of the `HashMap`s used for storage.
 #[derive(Default)]
-#[cfg_attr(feature = "cargo-clippy", allow(clippy::module_name_repetitions))]
+#[allow(clippy::module_name_repetitions)]
 pub struct NameMapping {
     /// The exports in the type namespace.
     type_map: HashMap<Symbol, (OptionalExport, OptionalExport)>,

src/mismatch.rs

@@ -21,7 +21,7 @@ use std::collections::{HashMap, HashSet, VecDeque};
 /// Keeps track of item pairs found that way that correspond to item matchings not yet known.
 /// This allows to match up some items that aren't exported, and which possibly even differ in
 /// their names across versions.
-#[cfg_attr(feature = "cargo-clippy", allow(clippy::module_name_repetitions))]
+#[allow(clippy::module_name_repetitions)]
 pub struct MismatchRelation<'a, 'tcx> {
     /// The type context used.
     tcx: TyCtxt<'tcx>,

src/traverse.rs

@@ -121,7 +121,7 @@ pub fn run_traversal(tcx: TyCtxt, new: DefId) {
 /// Traverse the two root modules in an interleaved manner, matching up pairs of modules
 /// from the two crate versions and compare for changes. Matching children get processed
 /// in the same fashion.
-#[cfg_attr(feature = "cargo-clippy", allow(clippy::cognitive_complexity))]
+#[allow(clippy::cognitive_complexity)]
 fn diff_structure<'tcx>(
     changes: &mut ChangeSet,
     id_mapping: &mut IdMapping,