You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: src/2025h1/annotate-snippets.md
+5-29Lines changed: 5 additions & 29 deletions
Original file line number
Diff line number
Diff line change
@@ -18,13 +18,13 @@ Cargo has been [adding its own linting system][cargo-lints], where it has been u
18
18
19
19
### The status quo
20
20
21
-
Currently rustc has its own Emitter that encodes the theming properties of compiler diagnostics. It has handle all of the intricancies of terminal support (optional color, terminal width querying and adapting of output), layout (span and label rendering logic), and the presentation of different levels of information. Any tool that wants to approximate rustc's output for their own purposes, needs to use a third-party tool that diverges from rustc's output, like annotate-snippets or miette. Any improvements or bugfixes contributed to those libraries are not propagated back to rustc. Because the emitter is part of the rustc codebase, the barrier to entry for new contributors is artificially kept high than it otherwise would be.
21
+
Currently rustc has its own Emitter that encodes the theming properties of compiler diagnostics. It has handle all of the intricacies of terminal support (optional color, terminal width querying and adapting of output), layout (span and label rendering logic), and the presentation of different levels of information. Any tool that wants to approximate rustc's output for their own purposes, needs to use a third-party tool that diverges from rustc's output, like annotate-snippets or miette. Any improvements or bugfixes contributed to those libraries are not propagated back to rustc. Because the emitter is part of the rustc codebase, the barrier to entry for new contributors is artificially kept high than it otherwise would be.
22
22
23
23
annotate-snippets is already part of the rustc codebase, but it is disabled by default, doesn't have extensive testing and there's no way of enabling this output through cargo, which limits how many users can actually make use of it.
24
24
25
25
### The next 6 months
26
26
27
-
- annotate-snippets rendered output reaches full partity (modulo reasonable non-significant divergences) with rustc's output
27
+
- annotate-snippets rendered output reaches full parity (modulo reasonable non-significant divergences) with rustc's output
28
28
- rustc is fully using annotate-snippets for their output.
29
29
30
30
### The "shiny future" we are working towards
@@ -33,10 +33,7 @@ The outputs of rustc and cargo are fully using annotate-snippets, with no regres
33
33
34
34
## Design axioms
35
35
36
-
*This section is optional, but including [design axioms][da] can help you signal how you intend to balance constraints and tradeoffs (e.g., "prefer ease of use over performance" or vice versa). Teams should review the axioms and make sure they agree. [Read more about design axioms][da].*
37
-
38
-
39
-
-**Match rustc's output**: The output of annotate-snipepts should match rustc, modulo reasonable non-significant divergences
36
+
-**Match rustc's output**: The output of annotate-snippets should match rustc, modulo reasonable non-significant divergences
40
37
-**Works for Cargo (and other tools)**: annotate-snippets is meant to be used by any project that would like "Rust-style" output, so it should be designed to work with any project, not just rustc.
41
38
42
39
@@ -46,21 +43,6 @@ The outputs of rustc and cargo are fully using annotate-snippets, with no regres
46
43
47
44
**Owner:**@estebank, @Muscraft
48
45
49
-
*Identify a specific person or small group of people if possible, else the group that will provide the owner*
50
-
51
-
This section defines the specific work items that are planned and who is expected to do them. It should also include what will be needed from Rust teams.
52
-
53
-
* Subgoal:
54
-
* Describe the work to be done and use `↳` to mark "subitems".
55
-
* Owner(s) or team(s):
56
-
* List the owner for this item (who will do the work) or ![Help wanted][] if an owner is needed.
57
-
* If the item is a "team ask" (i.e., approve an RFC), put ![Team][] and the team name(s).
58
-
* Status:
59
-
* List ![Help wanted][] if there is an owner but they need support, for example funding.
60
-
* Other needs (e.g., complete, in FCP, etc) are also fine.
61
-
62
-
*Adjust the table below; some common examples are shown below.*
| Reach output parity of rustc/annotate-snippets |||
@@ -78,12 +60,6 @@ This section defines the specific work items that are planned and who is expecte
78
60
| ↳ switch ui tests to only check new output |||
79
61
| ↳ dedicated reviewer |![Team][][compiler]|@estebank will be the reviewer |
80
62
| Standard reviews |![Team][][compiler]||
81
-
| Top-level Rust blog post inviting feedback |
82
-
83
-
## Frequently asked questions
84
-
85
-
### What do I do with this space?
86
-
87
-
*This is a good place to elaborate on your reasoning above -- for example, why did you put the design axioms in the order that you did? It's also a good place to put the answers to any questions that come up during discussion. The expectation is that this FAQ section will grow as the goal is discussed and eventually should contain a complete summary of the points raised along the way.*
0 commit comments