Permanently switch to the orchestrator for evaluate/compile/execute

Author: shepmaster

.github/workflows/ci.yml

@@ -254,7 +254,6 @@ jobs:
         PLAYGROUND_UI_ROOT: server/build/
         PLAYGROUND_CORS_ENABLED: true
         PLAYGROUND_GITHUB_TOKEN: "${{ secrets.PLAYGROUND_GITHUB_TOKEN }}"
-        PLAYGROUND_ORCHESTRATOR_ENABLED: 1
         PLAYGROUND_EXECUTE_VIA_WEBSOCKET_THRESHOLD: 1.0
       run: |-
         killall -q ui || true

ci/workflows.yml

@@ -362,7 +362,6 @@ workflows:
               PLAYGROUND_UI_ROOT: server/build/
               PLAYGROUND_CORS_ENABLED: true
               PLAYGROUND_GITHUB_TOKEN: ${{ secrets.PLAYGROUND_GITHUB_TOKEN }}
-              PLAYGROUND_ORCHESTRATOR_ENABLED: 1
               PLAYGROUND_EXECUTE_VIA_WEBSOCKET_THRESHOLD: 1.0
             run: |-
               killall -q ui || true

ui/src/main.rs

@@ -45,7 +45,6 @@ struct Config {
     cors_enabled: bool,
     gh_token: Option<String>,
     metrics_token: Option<String>,
-    orchestrator_enabled: bool,
     feature_flags: FeatureFlags,
     port: u16,
     root: PathBuf,
@@ -100,8 +99,6 @@ impl Config {
 
         let cors_enabled = env::var_os("PLAYGROUND_CORS_ENABLED").is_some();
 
-        let orchestrator_enabled = env::var_os("PLAYGROUND_ORCHESTRATOR_ENABLED").is_some();
-
         let execute_via_websocket_threshold =
             env::var("PLAYGROUND_EXECUTE_VIA_WEBSOCKET_THRESHOLD")
                 .ok()
@@ -116,7 +113,6 @@ impl Config {
             cors_enabled,
             gh_token,
             metrics_token,
-            orchestrator_enabled,
             feature_flags,
             port,
             root,
@@ -135,10 +131,6 @@ impl Config {
         self.cors_enabled
     }
 
-    fn use_orchestrator(&self) -> bool {
-        self.orchestrator_enabled
-    }
-
     fn metrics_token(&self) -> Option<MetricsToken> {
         self.metrics_token.as_deref().map(MetricsToken::new)
     }
@@ -182,12 +174,6 @@ impl MetricsToken {
 enum Error {
     #[snafu(display("Sandbox creation failed: {}", source))]
     SandboxCreation { source: sandbox::Error },
-    #[snafu(display("Compilation operation failed: {}", source))]
-    Compilation { source: sandbox::Error },
-    #[snafu(display("Execution operation failed: {}", source))]
-    Execution { source: sandbox::Error },
-    #[snafu(display("Evaluation operation failed: {}", source))]
-    Evaluation { source: sandbox::Error },
     #[snafu(display("Linting operation failed: {}", source))]
     Linting { source: sandbox::Error },
     #[snafu(display("Expansion operation failed: {}", source))]

ui/src/metrics.rs

@@ -425,19 +425,6 @@ where
     track_metric_common_async(request, body, |_| {}).await
 }
 
-pub(crate) async fn track_metric_force_endpoint_async<Req, B, Resp>(
-    request: Req,
-    endpoint: Endpoint,
-    body: B,
-) -> sandbox::Result<Resp>
-where
-    Req: GenerateLabels,
-    for<'req> B: FnOnce(&'req Req) -> BoxFuture<'req, sandbox::Result<Resp>>,
-    Resp: SuccessDetails,
-{
-    track_metric_common_async(request, body, |labels| labels.endpoint = endpoint).await
-}
-
 async fn track_metric_common_async<Req, B, Resp, F>(
     request: Req,
     body: B,