Use HashMap::retain

Why didn't I use this before? It's been stable since 1.18...

Author: shepmaster

compiler/base/orchestrator/src/coordinator.rs

@@ -2430,15 +2430,8 @@ impl Commander {
                 }
 
                 Gc => {
-                    waiting = mem::take(&mut waiting)
-                        .into_iter()
-                        .filter(|(_job_id, tx)| !tx.is_closed())
-                        .collect();
-
-                    waiting_once = mem::take(&mut waiting_once)
-                        .into_iter()
-                        .filter(|(_job_id, tx)| !tx.is_closed())
-                        .collect();
+                    waiting.retain(|_job_id, tx| !tx.is_closed());
+                    waiting_once.retain(|_job_id, tx| !tx.is_closed());
                 }
             }
         }

ui/src/server_axum/websocket.rs

@@ -15,7 +15,6 @@ use snafu::prelude::*;
 use std::{
     collections::BTreeMap,
     convert::TryFrom,
-    mem,
     pin::pin,
     sync::{
         atomic::{AtomicU64, Ordering},
@@ -470,10 +469,8 @@ async fn handle_core(
             }
 
             GarbageCollection => {
-                active_executions = mem::take(&mut active_executions)
-                    .into_iter()
-                    .filter(|(_id, (_, tx))| tx.as_ref().is_some_and(|tx| !tx.is_closed()))
-                    .collect();
+                active_executions
+                    .retain(|_id, (_, tx)| tx.as_ref().is_some_and(|tx| !tx.is_closed()));
             }
 
             IdleTimeout | IdleRequest => {