Skip to content

Commit 463dcfe

Browse files
committed
Split the AceEditor into two files and use React.Suspense
This actually increases the number of requests by one. Previously: 1. Ace library 2. Ace theme 3. Ace keybinding This adds: 4. Our Ace React component This is on par with what the Monaco editor has been doing. Technically it's better for the people who use the simple editor, but probably slightly slower for the people using the default configuration.
1 parent 50bd432 commit 463dcfe

File tree

7 files changed

+368
-489
lines changed

7 files changed

+368
-489
lines changed

ui/frontend/.eslintrc.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,12 @@ module.exports = {
6060
},
6161
overrides: [
6262
{
63-
files: ['.eslintrc.js', 'editor/SimpleEditor.tsx', 'websocketMiddleware.ts'],
63+
files: [
64+
'.eslintrc.js',
65+
'editor/AceEditor.tsx',
66+
'editor/SimpleEditor.tsx',
67+
'websocketMiddleware.ts',
68+
],
6469
extends: ['prettier'],
6570
},
6671
],

ui/frontend/.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,6 @@ node_modules
1111

1212
# Slowly migrate files that we've touched
1313
!.eslintrc.js
14+
!editor/AceEditor.tsx
1415
!editor/SimpleEditor.tsx
1516
!websocketMiddleware.ts

0 commit comments

Comments
 (0)