Address ESLint @typescript-eslint/no-explicit-any

shepmaster · shepmaster · commit 37f44ebf1b38 · 2024-11-25T13:45:05.000-05:00
diff --git a/ui/frontend/ConfigElement.tsx b/ui/frontend/ConfigElement.tsx
@@ -11,7 +11,7 @@ interface EitherProps<T extends string> extends ConfigElementProps {
   aLabel?: string;
   bLabel?: string;
   value: T;
-  onChange: (_: T) => any;
+  onChange: (_: T) => void;
 }
 
 export const Either =
@@ -39,7 +39,7 @@ export const Either =
 interface SelectProps<T extends string> extends ConfigElementProps {
   children: React.ReactNode;
   value: T;
-  onChange: (_: T) => any;
+  onChange: (_: T) => void;
 }
 
 export const Select = <T extends string,>({ value, onChange, children, ...rest }: SelectProps<T>) => (
diff --git a/ui/frontend/Output.tsx b/ui/frontend/Output.tsx
@@ -31,7 +31,7 @@ interface TabProps {
   kind: Focus;
   focus?: Focus;
   label: string;
-  onClick: () => any;
+  onClick: () => void;
   tabProps: object;
 }
 
diff --git a/ui/frontend/Output/Execute.tsx b/ui/frontend/Output/Execute.tsx
@@ -24,7 +24,7 @@ const Execute: React.FC = () => {
 };
 
 interface WarningProps {
-  addMainFunction: () => any;
+  addMainFunction: () => void;
 }
 
 const Warning: React.FC<WarningProps> = props => (
diff --git a/ui/frontend/Router.tsx b/ui/frontend/Router.tsx
@@ -1,8 +1,8 @@
 import React from 'react';
-import { UnknownAction } from '@reduxjs/toolkit';
+import { Reducer, UnknownAction } from '@reduxjs/toolkit';
 
 import { createBrowserHistory as createHistory, Path, Location } from 'history';
-import { createRouter, PlainOrThunk } from './uss-router';
+import { createRouter, PlainOrThunk, RouterObject, StoreArg } from './uss-router';
 import UssRouter from './uss-router/Router';
 
 import qs from 'qs';
@@ -82,7 +82,7 @@ const locationToAction = (location: Location): PlainOrThunk<State, UnknownAction
 };
 
 export default class Router extends React.Component<RouterProps> {
-  private router: any;
+  private router: RouterObject<UnknownAction>;
 
   public constructor(props: RouterProps) {
     super(props);
@@ -104,6 +104,6 @@ export default class Router extends React.Component<RouterProps> {
 
 interface RouterProps {
   children: React.ReactNode;
-  store: any;
-  reducer: any;
+  store: StoreArg<State, UnknownAction>;
+  reducer: Reducer<State>;
 }
diff --git a/ui/frontend/SelectOne.tsx b/ui/frontend/SelectOne.tsx
@@ -7,7 +7,7 @@ interface SelectOneProps<T> {
   name: string;
   currentValue: T;
   thisValue: T;
-  changeValue: (_: T) => any;
+  changeValue: (_: T) => void;
 }
 
 export default class SelectOne<T> extends React.PureComponent<SelectOneProps<T>> {
diff --git a/ui/frontend/api.ts b/ui/frontend/api.ts
@@ -23,7 +23,9 @@ export function jsonGet(url: FetchArg): Promise<unknown> {
   });
 }
 
-export function jsonPost(url: FetchArg, body: Record<string, any>): Promise<unknown> {
+type ToJson = Parameters<typeof JSON.stringify>[0];
+
+export function jsonPost(url: FetchArg, body: ToJson): Promise<unknown> {
   return fetchJson(url, {
     method: 'post',
     body: JSON.stringify(body),
diff --git a/ui/frontend/editor/AceEditorCore.tsx b/ui/frontend/editor/AceEditorCore.tsx
@@ -64,7 +64,7 @@ const buildCrateAutocompleter = (autocompleteOnUse: boolean, crates: Crate[]): A
   },
 });
 
-function useRafDebouncedFunction<A extends any[]>(fn: (...args: A) => void, onCall?: (...args: A) => void) {
+function useRafDebouncedFunction<A extends unknown[]>(fn: (...args: A) => void, onCall?: (...args: A) => void) {
   const timeout = useRef<number>();
 
   return useCallback((...args: A): void => {
@@ -82,9 +82,9 @@ function useRafDebouncedFunction<A extends any[]>(fn: (...args: A) => void, onCa
 interface AceEditorProps {
   autocompleteOnUse: boolean;
   code: string;
-  execute: () => any;
+  execute: () => void;
   keybinding: string;
-  onEditCode: (_: string) => any;
+  onEditCode: (_: string) => void;
   position: Position;
   selection: Selection;
   theme: string;
diff --git a/ui/frontend/eslint.config.mjs b/ui/frontend/eslint.config.mjs
@@ -34,7 +34,6 @@ export default tseslint.config(
         },
       ],
 
-      '@typescript-eslint/no-explicit-any': 'off',
       '@typescript-eslint/no-unused-vars': [
         'error',
         {
diff --git a/ui/frontend/local_storage.spec.ts b/ui/frontend/local_storage.spec.ts
@@ -1,7 +1,9 @@
 import { deserialize } from './local_storage';
 
+type ToJson = Parameters<typeof JSON.stringify>[0];
+
 describe('restoring saved state', () => {
-  const easyDeserialize = (state: any) => {
+  const easyDeserialize = (state: string | ToJson) => {
     if (typeof state === 'string' || state === undefined) {
       return deserialize(state);
     } else {
diff --git a/ui/frontend/local_storage.ts b/ui/frontend/local_storage.ts
@@ -32,7 +32,7 @@ interface V2Configuration {
     processAssembly: ProcessAssembly;
   };
   code: string;
-  notifications: any;
+  notifications: object;
 }
 
 interface V1Configuration {
@@ -48,7 +48,7 @@ interface V1Configuration {
     processAssembly: ProcessAssembly;
   };
   code: string;
-  notifications: any;
+  notifications: object;
 }
 
 type CurrentConfiguration = V2Configuration;
diff --git a/ui/frontend/types.ts b/ui/frontend/types.ts
@@ -44,8 +44,8 @@ export type ChannelVersion = z.infer<typeof ChannelVersion>;
 
 export interface CommonEditorProps {
   code: string;
-  execute: () => any;
-  onEditCode: (_: string) => any;
+  execute: () => void;
+  onEditCode: (_: string) => void;
   position: Position;
   selection: Selection;
   crates: Crate[];
diff --git a/ui/frontend/types/react-prism.d.ts b/ui/frontend/types/react-prism.d.ts
diff --git a/ui/frontend/uss-router/Link.tsx b/ui/frontend/uss-router/Link.tsx
@@ -2,12 +2,13 @@ import React, { useContext, useCallback, MouseEventHandler } from 'react';
 
 import { Context } from './Router';
 import { useAppDispatch } from '../hooks';
+import { UnknownAction } from '@reduxjs/toolkit';
 
 type Anchor = JSX.IntrinsicElements['a'];
 type SlimAnchor = Omit<Anchor, 'action' | 'onClick'>;
 
 export interface LinkProps extends SlimAnchor {
-  action?: () => any;
+  action: () => UnknownAction;
   onClick?: () => void;
 }
 
diff --git a/ui/frontend/uss-router/Router.tsx b/ui/frontend/uss-router/Router.tsx
@@ -1,15 +1,16 @@
 import React, { createContext } from 'react';
+import { UnknownAction } from '@reduxjs/toolkit';
 
 import { RouterObject } from '.';
 
-export const Context = createContext<RouterObject | undefined>(undefined);
+export const Context = createContext<RouterObject<UnknownAction> | undefined>(undefined);
 
-interface RouterProps {
+interface RouterProps<A extends UnknownAction> {
   children: React.ReactNode;
-  router: RouterObject;
+  router: RouterObject<A>;
 }
 
-const Router: React.FC<RouterProps> = ({router, children}) => (
+const Router: React.FC<RouterProps<UnknownAction>> = ({router, children}) => (
   <Context.Provider value={router}>
     {children}
   </Context.Provider>
diff --git a/ui/frontend/uss-router/index.ts b/ui/frontend/uss-router/index.ts
@@ -1,34 +1,38 @@
 import { isEqual } from 'lodash-es';
-import { configureStore, ThunkAction, Reducer, Store, Action } from '@reduxjs/toolkit';
+import { configureStore, ThunkAction, Reducer, Store, UnknownAction } from '@reduxjs/toolkit';
 import { BrowserHistory, Location, Path } from 'history';
 
-export type PlainOrThunk<St, A extends Action<any>> = A | ThunkAction<void, St, unknown, A>;
+export type PlainOrThunk<St, A extends UnknownAction> = A | ThunkAction<void, St, unknown, A>;
+
+export type StoreArg<St, A extends UnknownAction> = Store<St, A> & {
+  dispatch: (a: PlainOrThunk<St, A>) => void;
+};
 
 // This is a... dense... attempt at saying "we accept any store with
 // any dispatch so long as it can handle the actions you create". It's
 // probably overly complicated, restrictive, and broad all at the same
 // time.
-interface CreateRouterArg<St, SubSt, A extends Action<any>> {
-  store: Store<St, A> & { dispatch: (a: PlainOrThunk<St, A>) => void }; //  |
+interface CreateRouterArg<St, SubSt, A extends UnknownAction> {
+  store: StoreArg<St, A>;
   reducer: Reducer<St>;
   history: BrowserHistory;
   stateSelector: (state: St) => SubSt;
   stateToLocation: (substate: St) => Partial<Path>;
   locationToAction: (location: Location) => PlainOrThunk<St, A> | null;
 }
 
-export interface RouterObject {
-  provisionalLocation: any;
+export interface RouterObject<A extends UnknownAction> {
+  provisionalLocation: (makeAction: () => A) => Partial<Path>;
 }
 
-export function createRouter<St, SubSt, A extends Action<any>>({
+export function createRouter<St, SubSt, A extends UnknownAction>({
   store,
   reducer,
   history,
   stateSelector,
   stateToLocation,
   locationToAction,
-}: CreateRouterArg<St, SubSt, A>): RouterObject {
+}: CreateRouterArg<St, SubSt, A>): RouterObject<A> {
   let interestingPrevState: SubSt;
 
   // Watch changes to the Redux state

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ interface TabProps {`
`31`	`31`	`kind: Focus;`
`32`	`32`	`focus?: Focus;`
`33`	`33`	`label: string;`
`34`		`- onClick: () => any;`
	`34`	`+ onClick: () => void;`
`35`	`35`	`tabProps: object;`
`36`	`36`	`}`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ const Execute: React.FC = () => {`
`24`	`24`	`};`
`25`	`25`
`26`	`26`	`interface WarningProps {`
`27`		`- addMainFunction: () => any;`
	`27`	`+ addMainFunction: () => void;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`const Warning: React.FC<WarningProps> = props => (`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ interface SelectOneProps<T> {`
`7`	`7`	`name: string;`
`8`	`8`	`currentValue: T;`
`9`	`9`	`thisValue: T;`
`10`		`- changeValue: (_: T) => any;`
	`10`	`+ changeValue: (_: T) => void;`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`export default class SelectOne<T> extends React.PureComponent<SelectOneProps<T>> {`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ export default tseslint.config(`
`34`	`34`	`},`
`35`	`35`	`],`
`36`	`36`
`37`		`- '@typescript-eslint/no-explicit-any': 'off',`
`38`	`37`	`'@typescript-eslint/no-unused-vars': [`
`39`	`38`	`'error',`
`40`	`39`	`{`