Upgrade ESLint to 9.15

Author: shepmaster

ui/frontend/.eslintrc.js

@@ -12,7 +12,6 @@ node_modules
 *.scss
 
 # Slowly migrate files that we've touched
-!.eslintrc.js
 !BuildMenu.tsx
 !ButtonSet.tsx
 !Header.tsx
@@ -32,6 +31,7 @@ node_modules
 !editor/MonacoEditorCore.tsx
 !editor/SimpleEditor.tsx
 !editor/rust_monaco_def.ts
+!eslint.config.mjs
 !hooks.ts
 !observer.ts
 !prism-shim.ts

ui/frontend/.prettierignore

@@ -2,8 +2,6 @@ import React from 'react';
 
 import * as styles from './Icon.module.css';
 
-/* eslint-disable max-len */
-
 // These icons came from Material Design originally
 // https://material.io/tools/icons/?icon=assignment&style=outline
 
@@ -30,7 +28,6 @@ export const MoreOptionsIcon = () => (
 
 export const MoreOptionsActiveIcon = () => (
   <svg className={styles.icon} height="18" viewBox="0 0 24 24" width="18" xmlns="http://www.w3.org/2000/svg">
-    {/* eslint-disable-next-line react/no-unknown-property */}
     <path fillRule="evenodd" fill="#428bca" d="M4,5 h16 a3,3 0 0,1 3,3 v8 a3,3 0 0,1 -3,3 h-16 a3,3 0 0,1 -3,-3 v-8 a3,3 0 0,1 3,-3 Z M6 10c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm12 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm-6 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z" />
   </svg>
 );

ui/frontend/Icon.tsx

@@ -0,0 +1,69 @@
+// @ts-check
+import { fixupPluginRules } from '@eslint/compat';
+import eslint from '@eslint/js';
+import reactPlugin from 'eslint-plugin-react';
+import reactHooksPlugin from 'eslint-plugin-react-hooks';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  reactPlugin.configs.flat.recommended,
+
+  {
+    plugins: {
+      'react-hooks': fixupPluginRules(reactHooksPlugin),
+    },
+
+    settings: {
+      react: {
+        version: 'detect',
+      },
+    },
+
+    rules: {
+      'no-restricted-syntax': [
+        'error',
+        {
+          message: 'Use `useAppDispatch` instead',
+          selector: 'CallExpression[callee.name="useDispatch"]',
+        },
+        {
+          message: 'Use `useAppSelector` instead',
+          selector: 'CallExpression[callee.name="useSelector"]',
+        },
+      ],
+
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          args: 'all',
+          argsIgnorePattern: '^_',
+          caughtErrors: 'all',
+          caughtErrorsIgnorePattern: '^_',
+          destructuredArrayIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          ignoreRestSiblings: true,
+        },
+      ],
+      '@typescript-eslint/no-use-before-define': [
+        'error',
+        {
+          functions: false,
+          variables: false,
+        },
+      ],
+
+      'react/jsx-boolean-value': ['error', 'never'],
+
+      ...reactHooksPlugin.configs.recommended.rules,
+
+      // Disabled to upgrade to eslint 9
+      'no-empty': 'off',
+      'no-useless-escape': 'off',
+      'no-fallthrough': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+    },
+  },
+);

ui/frontend/eslint.config.mjs

@@ -32,6 +32,7 @@
     "@babel/core": "^7.0.0",
     "@babel/preset-env": "^7.0.0",
     "@babel/preset-react": "^7.0.0",
+    "@eslint/compat": "^1.2.3",
     "@trivago/prettier-plugin-sort-imports": "^4.1.1",
     "@types/common-tags": "^1.8.1",
     "@types/jest": "^29.2.5",
@@ -44,18 +45,15 @@
     "@types/react-portal": "^4.0.4",
     "@types/route-parser": "^0.1.4",
     "@types/uuid": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^7.5.0",
-    "@typescript-eslint/parser": "^7.5.0",
     "autoprefixer": "^10.2.4",
     "babel-loader": "^9.1.2",
     "basename": "^0.1.2",
     "compression-webpack-plugin": "^11.0.0",
     "copy-webpack-plugin": "^12.0.2",
     "css-loader": "^7.1.2",
-    "eslint": "^8.6.0",
-    "eslint-config-prettier": "^9.0.0",
+    "eslint": "^9.15.0",
     "eslint-plugin-react": "^7.14.3",
-    "eslint-plugin-react-hooks": "^4.0.0",
+    "eslint-plugin-react-hooks": "^5.0.0",
     "glob": "^11.0.0",
     "html-webpack-plugin": "^5.2.0",
     "jest": "^29.3.1",
@@ -77,6 +75,7 @@
     "ts-jest": "^29.0.4",
     "ts-loader": "^9.2.3",
     "typescript": "^5.0.2",
+    "typescript-eslint": "^8.15.0",
     "typescript-plugin-css-modules": "^5.0.0",
     "webpack": "^5.24.3",
     "webpack-cli": "^5.0.1"