Skip to content

Commit 01bb4ab

Browse files
committed
Remove double negation in ConfigElement
1 parent 7c6bb8e commit 01bb4ab

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

ui/frontend/AdvancedOptionsMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const AdvancedOptionsMenu: React.FC = () => {
2626
<SelectConfig
2727
name="Edition"
2828
value={edition}
29-
isNotDefault={!isEditionDefault}
29+
isDefault={isEditionDefault}
3030
onChange={changeEdition}
3131
>
3232
<option value={Edition.Rust2015}>2015</option>
@@ -41,7 +41,7 @@ const AdvancedOptionsMenu: React.FC = () => {
4141
a={Backtrace.Disabled}
4242
b={Backtrace.Enabled}
4343
value={backtrace}
44-
isNotDefault={!isBacktraceDefault}
44+
isDefault={isBacktraceDefault}
4545
onChange={changeBacktrace}
4646
/>
4747
</MenuGroup>

ui/frontend/ConfigElement.tsx

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,21 @@ export const Select = <T extends string>({
7070
interface ConfigElementProps {
7171
children?: React.ReactNode;
7272
name: string;
73-
isNotDefault?: boolean;
73+
isDefault?: boolean;
7474
aside?: JSX.Element;
7575
}
7676

77-
const ConfigElement: React.FC<ConfigElementProps> = ({ name, isNotDefault, aside, children }) => (
78-
<MenuItem>
79-
<div className={styles.container}>
80-
<span className={isNotDefault ? styles.notDefault : styles.name}>{name}</span>
81-
<div className={styles.value}>{children}</div>
82-
</div>
83-
{aside}
84-
</MenuItem>
85-
);
77+
const ConfigElement: React.FC<ConfigElementProps> = ({ name, isDefault, aside, children }) => {
78+
const actuallyDefault = isDefault ?? true;
79+
const defaultStyle = actuallyDefault ? styles.name : styles.notDefault;
80+
81+
return (
82+
<MenuItem>
83+
<div className={styles.container}>
84+
<span className={defaultStyle}>{name}</span>
85+
<div className={styles.value}>{children}</div>
86+
</div>
87+
{aside}
88+
</MenuItem>
89+
);
90+
};

0 commit comments

Comments
 (0)