replace failure with anyhow

Author: klensy

Cargo.lock

@@ -10,7 +10,7 @@ aho-corasick = "0.7"
 atomicwrites = "0.4"
 bincode = "1.0"
 brotli = "3.3"
-failure = "0.1"
+anyhow = { version = "1.0", features = ["backtrace"]}
 futures = "0.3"
 fnv = "1.0"
 hex = "0.4"

Cargo.toml

@@ -1,6 +1,6 @@
 use crate::rla;
+use anyhow::Context;
 use brotli;
-use failure::ResultExt;
 use percent_encoding::{AsciiSet, CONTROLS};
 use std::fs;
 use std::io::{Read, Write};
@@ -28,7 +28,7 @@ const FILENAME_ENCODE_SET: AsciiSet = CONTROLS
 
 pub fn save_compressed(out: &Path, data: &[u8]) -> rla::Result<()> {
     let mut writer = brotli::CompressorWriter::new(
-        fs::File::create(out).with_context(|_| format!("save_compressed: {:?}", out.to_owned()))?,
+        fs::File::create(out).with_context(|| format!("save_compressed: {:?}", out.to_owned()))?,
         BROTLI_BUFFER,
         BROTLI_QUALITY,
         BROTLI_LGWIN,

src/bin/offline/fs.rs

@@ -7,8 +7,6 @@
 
 extern crate brotli;
 #[macro_use]
-extern crate failure;
-#[macro_use]
 extern crate tracing;
 extern crate rust_log_analyzer as rla;
 extern crate walkdir;

src/bin/rla-offline.rs

@@ -5,8 +5,6 @@
     clippy::useless_let_if_seq
 )]
 
-#[macro_use]
-extern crate failure;
 extern crate futures;
 extern crate hyper;
 #[macro_use]

src/bin/rla-server.rs

@@ -1,6 +1,7 @@
 use super::{QueueItem, QueueItemKind};
 
 use crate::rla;
+use anyhow::bail;
 use hyper::{self, Body, Method, StatusCode};
 use hyper::{Request, Response};
 use serde_json;

src/bin/server/service.rs

@@ -2,6 +2,7 @@ use super::{QueueItem, QueueItemKind};
 
 use crate::rla;
 use crate::rla::ci::{self, BuildCommit, CiPlatform};
+use anyhow::bail;
 use std::collections::{HashSet, VecDeque};
 use std::hash::Hash;
 use std::path::PathBuf;
@@ -228,7 +229,7 @@ impl Worker {
                 let s = &commit_message[BORS_MERGE_PREFIX.len()..];
                 (
                     s[..s.find(' ').ok_or_else(|| {
-                        format_err!("Invalid bors commit message: '{}'", commit_message)
+                        anyhow::format_err!("Invalid bors commit message: '{}'", commit_message)
                     })?]
                         .parse()?,
                     true,

src/bin/server/worker.rs

@@ -1,5 +1,5 @@
 use crate::rla;
-use failure::ResultExt;
+use anyhow::Context;
 use std::process;
 
 #[derive(Debug, Copy, Clone)]
@@ -13,26 +13,26 @@ impl CliCiPlatform {
         Ok(match self {
             CliCiPlatform::Azure => {
                 let token = std::env::var("AZURE_DEVOPS_TOKEN")
-                    .with_context(|_| "failed to read AZURE_DEVOPS_TOKEN env var")?;
+                    .with_context(|| "failed to read AZURE_DEVOPS_TOKEN env var")?;
                 Box::new(rla::ci::AzurePipelines::new(&token))
             }
             CliCiPlatform::Actions => {
                 let token = std::env::var("GITHUB_TOKEN")
-                    .with_context(|_| "failed to read GITHUB_TOKEN env var")?;
+                    .with_context(|| "failed to read GITHUB_TOKEN env var")?;
                 Box::new(rla::ci::GitHubActions::new(&token))
             }
         })
     }
 }
 
 impl std::str::FromStr for CliCiPlatform {
-    type Err = failure::Error;
+    type Err = anyhow::Error;
 
     fn from_str(input: &str) -> rla::Result<Self> {
         Ok(match input {
             "azure" => CliCiPlatform::Azure,
             "actions" => CliCiPlatform::Actions,
-            other => bail!("unknown CI platform: {}", other),
+            other => anyhow::bail!("unknown CI platform: {}", other),
         })
     }
 }

src/bin/util/mod.rs

@@ -303,7 +303,7 @@ fn fetch_workflow_run_id_from_check_run(
         }
     }
 
-    bail!("can't find the Workflow Run ID from the Check Run");
+    anyhow::bail!("can't find the Workflow Run ID from the Check Run");
 }
 
 #[derive(Debug, Eq, PartialEq, Hash)]
@@ -332,7 +332,7 @@ fn parse_link_header(content: &str) -> Result<HashMap<LinkRel, String>> {
             };
             result.insert(rel, captures[1].into());
         } else {
-            failure::bail!("invalid link header entry: {}", entry);
+            anyhow::bail!("invalid link header entry: {}", entry);
         }
     }
     Ok(result)

src/ci/actions.rs

@@ -1,7 +1,7 @@
 #![allow(unused)]
 use crate::ci::{Build, BuildCommit, CiPlatform, Job, Outcome};
 use crate::Result;
-use failure::ResultExt;
+use anyhow::Context;
 use reqwest::blocking::{Client as ReqwestClient, Response};
 use reqwest::{Method, StatusCode};
 use std::borrow::Cow;
@@ -185,7 +185,7 @@ impl AzureBuild {
             return Ok(None);
         }
         let dbg = format!("{:?}", resp);
-        let timeline: Timeline = resp.json().with_context(|_| dbg)?;
+        let timeline: Timeline = resp.json().with_context(|| dbg)?;
         Ok(Some(AzureBuild {
             jobs: timeline
                 .records
@@ -354,7 +354,7 @@ impl CiPlatform for Client {
         if let Some(build) = AzureBuild::new(&self, repo, data)? {
             Ok(Box::new(build))
         } else {
-            Err(failure::err_msg("no build results"))
+            Err(anyhow::anyhow!("no build results"))
         }
     }