Skip to content

Commit dd3e568

Browse files
committed
Address feedback
1 parent 42e8c1a commit dd3e568

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/infra/docs/bors.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ failed are re-approved again on their own.
2121

2222
There are multiple steps needed to add a repository to our Bors instance:
2323

24-
1. Each CI provider needs to have a single GitHub Check Run to gate on. This is
24+
1. The [@bors] GitHub account needs to be granted write access to the
25+
repository.
26+
27+
2. Each CI provider needs to have a single GitHub Check Run to gate on. This is
2528
not provided by default on GitHub Actions, but it can be simulated with
2629
these two jobs, which will generate a `bors build finished` check:
2730

@@ -56,26 +59,25 @@ There are multiple steps needed to add a repository to our Bors instance:
5659
on:
5760
push:
5861
branches: [
59-
master, # This is any branch you normally run CI on
6062
auto, # Added for bors
6163
try # Added for bors
6264
]
6365
```
6466

65-
2. Add the repository name to the bors permissions array in the [team
67+
3. Add the repository name to the bors permissions array in the [team
6668
repository][team-permissions.rs], and grant the `bors.REPOSITORY.review`
6769
permission to the right teams or people. You can see an example of adding
6870
bors permissions to a team [here][bors-permission].
6971

70-
3. Add the repository to the `repositories` map in [the Terraform configuration
72+
4. Add the repository to the `repositories` map in [the Terraform configuration
7173
file][tf-repos]. This will create a webhook and inject its secret key in the
7274
bors execution environment.
7375

74-
4. Add the repository to the [Bors configuration][bors-config], taking
76+
5. Add the repository to the [Bors configuration][bors-config], taking
7577
inspiration from other repositories. Note that the environment variables used
7678
in that config will be set automatically as long as you completed step 3 above.
7779

78-
5. Give it a test by commenting `@bors ping` in any PR. If you get a response back,
80+
6. Give it a test by commenting `@bors ping` in any PR. If you get a response back,
7981
you can then try to approve the PR with `@bors r+`.
8082

8183
[@bors]: https://github.com/bors

0 commit comments

Comments
 (0)