Skip to content

Commit dbb034a

Browse files
committed
Grant infra-admins permissions for repo changes
The `repo` directory manages both access as well as the configuration and automation of repositories. Since all repositories are now managed by the team repo and we are adding more and more automation, it makes sense to give the infra-admins the authority to approve and merge these configuration changes, while permission changes still need to be approved by the team-repo-admins.
1 parent 27eaf9a commit dbb034a

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

src/infra/team-maintenance.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ systems integrated with it.
1616

1717
Pull requests to the repository are merged by the [team-repo-admins], who use these rules to merge PRs:
1818

19-
### `people`, `teams`, and `repos` directories
19+
### `people` and `teams` directories
2020

2121
If a change is related to an individual and does not expand permissions, then only the individual's approval is required. If the change has already been made outside of the team repo (e.g., GitHub username change) then it is considered implicitly approved. This non-exhaustively includes:
2222

@@ -28,14 +28,29 @@ If a change will grant additional permissions, then a team lead needs to
2828
approve the change. Any team lead in the "parent team" chain may do so. This includes:
2929

3030
* Adding new subteams under an existing team
31-
* Granting additional access (bors, dev-desktop access, etc.)
3231
* Changing other metadata (website descriptions, Zulip groups, etc.)
32+
33+
### `repo` directory
34+
35+
The `repo` directory differs slightly from the other directories in that it is
36+
not only used to manage access to repositories, but also configures them and
37+
manages their automation.
38+
39+
The following changes must be approved and merged by a `team-repo-admin`:
40+
3341
* Changing access to repositories owned by their team
3442
* For repositories ownership is not currently formally tracked. Until that is
3543
added, the team-repo-admins are expected to exercise their understanding of
3644
which team owns the repository, when in doubt asking for clarification and
3745
codifying in a comment in the relevant repository.
3846

47+
On the other hand, changes to the configuration or automation of repositories
48+
may be approved and merged by `infra-admins`:
49+
50+
* Changing the [general repository settings](https://github.com/rust-lang/team/blob/master/docs/toml-schema.md#general-repository-settings)
51+
* This includes granting bots access to the repository.
52+
* Changing the [repository branch protections](https://github.com/rust-lang/team/blob/master/docs/toml-schema.md#repository-branch-protections)
53+
3954
### Source code changes
4055

4156
The team repository additionally contains code to transform and validate the

0 commit comments

Comments
 (0)