You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minor tweaks about WG-Prioritization procedure (#405)
* Prioritization procedure: Expand information about follow ups
* Prioritization procedure: Reorder procedure items a bit better
* Prioritization procedure: merge prioritization of regressions with I-prioritize issues
Is not important to have a step for regressions because regressions are
automatically labelled as `I-prioritize` and then covered by the
previous section.
- Add `T-compiler` and `libs-impl` to unlabelled T-compiler and libs-impl issues
28
28
- Assign priority to unprioritized issues with "I-prioritize" label
29
-
- Assign priority to regressions without a `P-*` label
30
29
- Process MCPs/FCPs
31
30
-[Generate Agenda](#generate-agenda)
32
31
- Run cli to generate agenda
33
32
- Fill agenda announcements
34
33
- Add performance logs
34
+
-[Notify the team about the meeting](#notify-the-team-about-the-meeting)
35
+
- Figure out which WGs need to check-in
36
+
- Notify @T-compiler/meeting about the meeting on Zulip
37
+
-[Add details to the Agenda](#add-details-to-the-agenda)
35
38
- Summarize stable/beta nominations
36
39
- Summarize PR's waiting on team
37
40
- Summarize `P-critical` and unassigned `P-high` regressions
38
41
- Summarize I-nominated issues
39
-
-[Notify the team about the meeting](#notify-the-team-about-the-meeting)
40
-
- Figure out which WGs need to check-in
41
-
- Notify @T-compiler/meeting about the meeting on Zulip
42
42
-[Final reviews](#final-reviews)
43
43
- Check toolstate
44
44
- Check performance stats
@@ -48,9 +48,9 @@ High level overview:
48
48
### Follow ups from previous meeting
49
49
50
50
- Remove [`I-nominated`](https://github.com/rust-lang/rust/labels/I-nominated) tags of already discussed issues. For that check previous week agenda and Zulip meeting
51
-
- Notify [@pnkfelix](https://rust-lang.zulipchat.com/#narrow/pm-with/116083-user116083) about accepted [`beta nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted) and [`stable nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted) without `beta-accepted` and `stable-accepted` label
52
-
- Notify @pnkfelix about rejected [`beta nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted) and [`stable nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted) still with the nominated label
53
-
- Create an empty agenda using [our template](https://hackmd.io/WQW0yzDDS16YvtBNurmj6A), as soon as our Thursday's weekly meeting ends
51
+
- Notify [@pnkfelix](https://rust-lang.zulipchat.com/#narrow/pm-with/116083-user116083) about accepted [`beta nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted) and [`stable nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted) without `beta-accepted` and `stable-accepted` label. For that compare these issues with list meeting's accepted nomations.
52
+
- Notify @pnkfelix about rejected [`beta nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted) and [`stable nominated`](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted) still with the nominated label. For that compare these issues with last meeting's rejected nominations.
53
+
- Create an empty agenda using [our template](https://hackmd.io/WQW0yzDDS16YvtBNurmj6A), as soon as our Thursday's weekly meeting ends. After creating the meeting change document permissions to Write -> Owners.
54
54
55
55
### Prepare agenda content
56
56
@@ -74,14 +74,7 @@ The procedure here follows the [General issues review process](#General-issues-r
74
74
75
75
Note: triagebot automatically creates a topic and notify @*WG-prioritization* members once an issue is labelled with `I-prioritize`
76
76
Note #2: These lists should typically be empty when we are close to the meeting.
77
-
78
-
#### Assign priority to regressions without a P-label
79
-
80
-
We should not have unprioritized regressions ([stable](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-stable+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc), [beta](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc) and [nightly](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc)) and ideally regressions should have an assignee.
81
-
82
-
The procedure here follows the [General issues review process](#general-issues-review-process).
83
-
84
-
Note: triagebot automatically adds `I-prioritize` to all regression issues and creates a topic and notify @*WG-prioritization* members requesting prioritization.
77
+
Note #3: we should not have unprioritized regressions ([stable](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-stable+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc), [beta](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc) and [nightly](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+-label%3AP-critical+-label%3AP-high+-label%3AP-medium+-label%3AP-low+-label%3AT-infra+-label%3AT-libs+-label%3AT-release+-label%3AT-rustdoc)) and ideally regressions should have an assignee.
85
78
86
79
#### Accept MCPs
87
80
@@ -124,6 +117,26 @@ For now fix announcements output manually. Remove the nonsense no fcps kind of l
124
117
125
118
Check the compiler calendar to see if there's an outstanding event to announce and add it to the agenda.
126
119
120
+
#### Add performance logs
121
+
122
+
Add [Triage Logs](https://github.com/rust-lang/rustc-perf/tree/master/triage#triage-logs) to the agenda.
123
+
124
+
### Notify the team about the meeting
125
+
126
+
[Figure out which working groups' check-ins follow](https://rust-lang.github.io/compiler-team/about/triage-meeting/).
127
+
Create `[weekly meeting] YYYY-MM-DD #54818` topic in `#t-compiler/meetings` Zulip's stream and send the following messages:
128
+
129
+
```text
130
+
Hi @*T-compiler/meeting*; the triage meeting will happen tomorrow at 2pm UTC
131
+
The @*WG-prioritization* have done pre-triage in #**t-compiler/wg-prioritization**
132
+
@*WG-prioritization* have prepared the [meeting agenda](link_to_hackmd_agenda)
133
+
We will have checkins from @*WG-X* and @*WG-Y*
134
+
@**person1** do you have something you want to share about @*WG-X*?
135
+
@**person2** do you have something you want to share about @*WG-Y*?
136
+
```
137
+
138
+
### Add details to the Agenda
139
+
127
140
#### Summarize stable/beta nominations
128
141
129
142
- Add them to the agenda explaining:
@@ -178,24 +191,6 @@ We should:
178
191
179
192
Note: triagebot automatically creates a topic and notify @*WG-prioritization* members requesting addition to the agenda.
180
193
181
-
#### Add performance logs
182
-
183
-
Add [Triage Logs](https://github.com/rust-lang/rustc-perf/tree/master/triage#triage-logs) to the agenda.
184
-
185
-
### Notify the team about the meeting
186
-
187
-
[Figure out which working groups' check-ins follow](https://rust-lang.github.io/compiler-team/about/triage-meeting/).
188
-
Create `[weekly meeting] YYYY-MM-DD #54818` topic in `#t-compiler/meetings` Zulip's stream and send the following messages:
189
-
190
-
```text
191
-
Hi @*T-compiler/meeting*; the triage meeting will happen tomorrow at 2pm UTC
192
-
The @*WG-prioritization* have done pre-triage in #**t-compiler/wg-prioritization**
193
-
@*WG-prioritization* have prepared the [meeting agenda](link_to_hackmd_agenda)
194
-
We will have checkins from @*WG-X* and @*WG-Y*
195
-
@**person1** do you have something you want to share about @*WG-X*?
196
-
@**person2** do you have something you want to share about @*WG-Y*?
0 commit comments