Skip to content

Commit 7338e41

Browse files
apirainodavidtwco
authored andcommitted
add details about promotion into compiler contributors team
1 parent c348920 commit 7338e41

File tree

1 file changed

+41
-5
lines changed

1 file changed

+41
-5
lines changed

src/compiler/membership.md

Lines changed: 41 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,20 @@ when they have demonstrated three things:
4343
Conduct][CoC]. They should not only obey the letter of the CoC but
4444
also its spirit.
4545

46-
[CoC]: https://www.rust-lang.org/policies/code-of-conduct
46+
[CoC]: https://www.rust-lang.org/policies/code-of-conduct
4747

4848
Being promoted to contributor implies a number of privileges:
4949

50-
- Contributors have r+ privileges and can do reviews (they are
51-
expected to use those powers appropriately, as discussed
52-
previously). They also have access to control perf/rustc-timer and
53-
other similar bots.
50+
- Contributors have `r+` (approve a pull request) privileges and can do reviews
51+
(they are expected to use those powers appropriately, as discussed
52+
previously). They also have access to control perf/rustc-timer and other
53+
similar bots. See the documentation for `bors` and `r+`
54+
[here](https://rustc-dev-guide.rust-lang.org/compiler-team.html#team-membership).
55+
56+
Tip: some baseline rules around bors permissions are: don't do a `try` build
57+
unless you have done a check for malicious code first and don't `r+` unless
58+
you are reasonably confident that you can effectively review the code in
59+
question.
5460
- Contributors are members of the organization so they can modify
5561
labels and be assigned to issues.
5662
- Contributors are a member of the rust-lang/compiler team on GitHub,
@@ -64,6 +70,36 @@ It also implies some obligations (in some cases, optional obligations):
6470
- Contributors are held to a higher standard than ordinary folk when
6571
it comes to the [Code of Conduct][CoC].
6672

73+
## What it means to be a compiler contributor
74+
75+
Once you're a member of the compiler team contributors, a number of events will
76+
happen:
77+
- You will gain access to a private Zulip stream, where internal discussions
78+
happen or ideas in very draft state are shared. Come and say hello to your new
79+
team members!
80+
- You will be subscribed and gain write access to the following Github repositories:
81+
- [rust-lang/rustc_apfloat](https://github.com/rust-lang/rustc_apfloat)
82+
- [rust-lang/ar_archive_writer](https://github.com/rust-lang/ar_archive_writer)
83+
- [rust-lang/project-thir-unsafeck](https://github.com/rust-lang/project-thir-unsafeck)
84+
- [rust-lang/odht](https://github.com/rust-lang/odht)
85+
- [rust-lang/wg-incr-comp](https://github.com/rust-lang/wg-incr-comp)
86+
- [rust-lang/project-rfc-2229](https://github.com/rust-lang/project-rfc-2229)
87+
- [rust-lang/rustc-demangle](https://github.com/rust-lang/rustc-demangle)
88+
- [rust-lang/surveys-private](https://github.com/rust-lang/surveys-private)
89+
- [rust-lang/rfcs](https://github.com/rust-lang/rfcs)
90+
91+
Some of them are pretty quiet or obsolete, so don't worry about all of them.
92+
93+
Tip: Github automatically adds you as subscriber to every repo you get write
94+
permission too. You can disable this in the settings
95+
([here](https://github.com/settings/notifications)).
96+
97+
- You will also be subscribed to the `all@rust-lang.org` mailing list. See
98+
[this file](https://github.com/rust-lang/team/blob/HEAD/teams/all.toml) to
99+
check how subscriptions to mailing lists work. It's a very low-volume mailing
100+
list (maybe a few emails per year), it's a way to communicate things to all
101+
contributors. You will not receive spam from this address.
102+
67103
## Full members
68104

69105
As a contributor gains in experience, they may be asked to become a

0 commit comments

Comments
 (0)