Skip to content

Commit 56ffc8e

Browse files
committed
Minor clarifications on FCPs and MCP approval process
1 parent 3986be0 commit 56ffc8e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/compiler/proposals-and-stabilization.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ are suitable for each method of making a proposal - see below):
1818
other team members to raise any concerns.
1919
- Seconding can only be used to approve a MCP.
2020
- FCP
21-
- A final comment period will require sign-off from a majority of the compiler team to approve
22-
a proposal and then a ten day waiting period.
21+
- A final comment period will require sign-off from the compiler FCP reviewers (the
22+
[`compiler-fcp` subteam][compiler-fcp]) to approve a proposal and then a ten day waiting period.
2323
- FCPs can be used to approve any form of proposal.
2424

2525
## Proposals
@@ -59,6 +59,9 @@ the nature of the proposal, described below.
5959
* The FCP can be skipped if the change is easily reversed and/or further objections are
6060
considered unlikely. This often happens if there has been a lot of prior discussion, for
6161
example.
62+
* Outstanding concerns block the final comment period from completing.
63+
* When all outstanding concerns are resolved, the final comment period countdown is
64+
restarted.
6265
* Once the FCP completes, if there are no outstanding concerns, contributions can begin.
6366
* An earlier accepted MCP is not a substitute for any later necessary approvals.
6467

@@ -371,3 +374,4 @@ See [*Adding ecosystem/integration test jobs/components to rust-lang/rust CI*](.
371374
[rust]: https://github.com/rust-lang/rust
372375
[compiler_lint_eg]: https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#explicit-builtin-cfgs-in-flags
373376
[ecosystem_testing]: https://rustc-dev-guide.rust-lang.org/tests/ecosystem.html
377+
[compiler-fcp]: https://github.com/rust-lang/team/blob/master/teams/compiler-fcp.toml

0 commit comments

Comments
 (0)