@@ -18,8 +18,8 @@ are suitable for each method of making a proposal - see below):
18
18
other team members to raise any concerns.
19
19
- Seconding can only be used to approve a MCP.
20
20
- FCP
21
- - A final comment period will require sign-off from a majority of the compiler team to approve
22
- a proposal and then a ten day waiting period.
21
+ - A final comment period will require sign-off from the compiler FCP reviewers (the
22
+ [ ` compiler-fcp ` subteam ] [ compiler-fcp ] ) to approve a proposal and then a ten day waiting period.
23
23
- FCPs can be used to approve any form of proposal.
24
24
25
25
## Proposals
@@ -59,6 +59,9 @@ the nature of the proposal, described below.
59
59
* The FCP can be skipped if the change is easily reversed and/or further objections are
60
60
considered unlikely. This often happens if there has been a lot of prior discussion, for
61
61
example.
62
+ * Outstanding concerns block the final comment period from completing.
63
+ * When all outstanding concerns are resolved, the final comment period countdown is
64
+ restarted.
62
65
* Once the FCP completes, if there are no outstanding concerns, contributions can begin.
63
66
* An earlier accepted MCP is not a substitute for any later necessary approvals.
64
67
@@ -371,3 +374,4 @@ See [*Adding ecosystem/integration test jobs/components to rust-lang/rust CI*](.
371
374
[ rust ] : https://github.com/rust-lang/rust
372
375
[ compiler_lint_eg ] : https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#explicit-builtin-cfgs-in-flags
373
376
[ ecosystem_testing ] : https://rustc-dev-guide.rust-lang.org/tests/ecosystem.html
377
+ [ compiler-fcp ] : https://github.com/rust-lang/team/blob/master/teams/compiler-fcp.toml
0 commit comments