Skip to content

Commit 2e1c61c

Browse files
nikomatsakisjonas-schievinkshepmasterLeSeulArtichaut
authored
describe how to create a notification group (#393)
* describe how to create a notification group * Update src/compiler/notification-groups.md Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> * Update src/compiler/notification-groups.md Co-authored-by: Jake Goulding <shepmaster@mac.com> * Update src/compiler/notification-groups.md Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com> * Update src/compiler/notification-groups.md Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Jake Goulding <shepmaster@mac.com> Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
1 parent 5cf0a77 commit 2e1c61c

File tree

2 files changed

+40
-0
lines changed

2 files changed

+40
-0
lines changed

src/SUMMARY.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
- [So you want to add a new option to rustc?](./compiler/new_option.md)
2121
- [Major Change Proposals](./compiler/mcp.md)
2222
- [Membership](./compiler/membership.md)
23+
- [Notification groups](./compiler/notification-groups.md)
2324
- [Triage Meeting](./compiler/triage-meeting.md)
2425
- [Steering Meeting](./compiler/steering-meeting.md)
2526
- [Submitting a proposal](./compiler/steering-meeting/submit.md)

src/compiler/notification-groups.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# Notification groups
2+
3+
The compiler team has a number of notification groups that we use to
4+
ping people and draw their attention to issues. Notification groups
5+
are setup so that anyone can join them if they want.
6+
7+
## Creating a notification group
8+
9+
If you'd like to create a notification group, here are the steps.
10+
First, you want to get approval from the compiler team:
11+
12+
* Propose the group by preparing a [Major Change Proposal][MCP]. If
13+
your group is not analogous to some existing group, it is probably
14+
a good idea to ping compiler team leads before-hand or as part of
15+
the MCP.
16+
* The MCP should specify what GitHub label will be associated with the
17+
notification group. Often this is an existing label, such as
18+
`O-Windows`.
19+
20+
Once the MCP is accepted, here are the steps to actually create the group.
21+
In some cases we include an example PR from some other group.
22+
23+
* File a tracking issue in the rust-lang/compiler-team repository to collect
24+
your progress.
25+
* Create a PR against the rust-lang/team repository adding the notification
26+
group. [Example PR.](https://github.com/rust-lang/team/pull/347)
27+
* Configure the rust-lang/rust repository to accept triagebot commands
28+
for this group. [Example PR.](https://github.com/rust-lang/rust/pull/72706)
29+
* Create a PR for the rustc-dev-guide amending [the notification group
30+
section](https://rustc-dev-guide.rust-lang.org/notification-groups/about.html)
31+
to mention your group.
32+
* Create a sample PR for the rust-lang/team repository showing how one can add
33+
oneself. This will be referenced by your blog post to show people how to
34+
join. [Example PR.](https://github.com/rust-lang/team/pull/140)
35+
* Write an announcement blog post for Inside Rust and open a PR against
36+
[blog.rust-lang.org](https://github.com/rust-lang/blog.rust-lang.org).
37+
[Example PR.](https://github.com/rust-lang/blog.rust-lang.org/pull/615)
38+
39+
[MCP]: ./mcp.md

0 commit comments

Comments
 (0)