@@ -18,10 +18,9 @@ are suitable for each method of making a proposal - see below):
18
18
other team members to raise any concerns.
19
19
- Seconding can only be used to approve a MCP.
20
20
- FCP
21
- - A Final Comment Period is started by a T-compiler member, it's a tool to get concrete consensus
22
- from the team.
23
- - Requires sign-off from a majority of the compiler team to approve a proposal and then a ten days
24
- waiting period.
21
+ - A Final Comment Period is started by a T-compiler member. it's a tool to get concrete consensus
22
+ from the team. This requires sign-off from the compiler FCP reviewers (the [ ` compiler-fcp `
23
+ subteam] [ compiler-fcp ] ) to approve a proposal and then a ten day waiting period.
25
24
- FCPs can be used to approve any form of proposal.
26
25
27
26
## Proposals
@@ -61,6 +60,9 @@ the nature of the proposal, described below.
61
60
* The FCP can be skipped if the change is easily reversed and/or further objections are
62
61
considered unlikely. This often happens if there has been a lot of prior discussion, for
63
62
example.
63
+ * Outstanding concerns block the final comment period from completing.
64
+ * When all outstanding concerns are resolved, the final comment period countdown is
65
+ restarted.
64
66
* Once the FCP completes, if there are no outstanding concerns, contributions can begin.
65
67
* An earlier accepted MCP is not a substitute for any later necessary approvals.
66
68
@@ -373,3 +375,4 @@ See [*Adding ecosystem/integration test jobs/components to rust-lang/rust CI*](.
373
375
[ rust ] : https://github.com/rust-lang/rust
374
376
[ compiler_lint_eg ] : https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#explicit-builtin-cfgs-in-flags
375
377
[ ecosystem_testing ] : https://rustc-dev-guide.rust-lang.org/tests/ecosystem.html
378
+ [ compiler-fcp ] : https://github.com/rust-lang/team/blob/master/teams/compiler-fcp.toml
0 commit comments