Make epsilon note spanless when comparing arrays

Author: marcin-serwin

clippy_lints/src/misc.rs

@@ -391,8 +391,10 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MiscLints {
                                 ),
                                 Applicability::HasPlaceholders, // snippet
                             );
+                            db.span_note(expr.span, "`std::f32::EPSILON` and `std::f64::EPSILON` are available.");
+                        } else {
+                            db.note("`std::f32::EPSILON` and `std::f64::EPSILON` are available.");
                         }
-                        db.span_note(expr.span, "`std::f32::EPSILON` and `std::f64::EPSILON` are available.");
                     });
                 } else if op == BinOpKind::Rem && is_integer_const(cx, right, 1) {
                     span_lint(cx, MODULO_ONE, expr.span, "any number modulo 1 will be 0");

tests/ui/float_cmp.stderr

@@ -53,11 +53,7 @@ error: strict comparison of `f32` or `f64`
 LL |     a1 == a2;
    |     ^^^^^^^^
    |
-note: `std::f32::EPSILON` and `std::f64::EPSILON` are available.
-  --> $DIR/float_cmp.rs:98:5
-   |
-LL |     a1 == a2;
-   |     ^^^^^^^^
+   = note: `std::f32::EPSILON` and `std::f64::EPSILON` are available.
 
 error: strict comparison of `f32` or `f64`
   --> $DIR/float_cmp.rs:99:5

tests/ui/float_cmp_const.stderr

@@ -89,11 +89,7 @@ error: strict comparison of `f32` or `f64` constant
 LL |     NON_ZERO_ARRAY == NON_ZERO_ARRAY2;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-note: `std::f32::EPSILON` and `std::f64::EPSILON` are available.
-  --> $DIR/float_cmp_const.rs:61:5
-   |
-LL |     NON_ZERO_ARRAY == NON_ZERO_ARRAY2;
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   = note: `std::f32::EPSILON` and `std::f64::EPSILON` are available.
 
 error: aborting due to 8 previous errors