may_not_refer_to_existing_definition -> allow_invalid

Author: smoelius

clippy.toml

@@ -7,14 +7,14 @@ lint-commented-code = true
 [[disallowed-methods]]
 path = "rustc_lint::context::LintContext::lint"
 reason = "this function does not add a link to our documentation, please use the `clippy_utils::diagnostics::span_lint*` functions instead"
-may-not-refer-to-existing-definition = true
+allow-invalid = true
 
 [[disallowed-methods]]
 path = "rustc_lint::context::LintContext::span_lint"
 reason = "this function does not add a link to our documentation, please use the `clippy_utils::diagnostics::span_lint*` functions instead"
-may-not-refer-to-existing-definition = true
+allow-invalid = true
 
 [[disallowed-methods]]
 path = "rustc_middle::ty::context::TyCtxt::node_span_lint"
 reason = "this function does not add a link to our documentation, please use the `clippy_utils::diagnostics::span_lint_hir*` functions instead"
-may-not-refer-to-existing-definition = true
+allow-invalid = true

clippy_config/src/types.rs

@@ -23,12 +23,12 @@ pub struct DisallowedPath<const REPLACEMENT_ALLOWED: bool = true> {
     path: String,
     reason: Option<String>,
     replacement: Option<String>,
-    /// Setting `may_not_refer_to_existing_definition` to true suppresses a warning if `path` does
-    /// not refer to an existing definition.
+    /// Setting `allow_invalid` to true suppresses a warning if `path` does not refer to an existing
+    /// definition.
     ///
     /// This could be useful when conditional compilation is used, or when a clippy.toml file is
     /// shared among multiple projects.
-    may_not_refer_to_existing_definition: bool,
+    allow_invalid: bool,
     /// The span of the `DisallowedPath`.
     ///
     /// Used for diagnostics.
@@ -49,7 +49,7 @@ impl<'de, const REPLACEMENT_ALLOWED: bool> Deserialize<'de> for DisallowedPath<R
             path: enum_.path().to_owned(),
             reason: enum_.reason().map(ToOwned::to_owned),
             replacement: enum_.replacement().map(ToOwned::to_owned),
-            may_not_refer_to_existing_definition: enum_.may_not_refer_to_existing_definition(),
+            allow_invalid: enum_.allow_invalid(),
             span: Span::default(),
         })
     }
@@ -65,8 +65,8 @@ enum DisallowedPathEnum {
         path: String,
         reason: Option<String>,
         replacement: Option<String>,
-        #[serde(rename = "may-not-refer-to-existing-definition")]
-        may_not_refer_to_existing_definition: Option<bool>,
+        #[serde(rename = "allow-invalid")]
+        allow_invalid: Option<bool>,
     },
 }
 
@@ -120,12 +120,9 @@ impl DisallowedPathEnum {
         }
     }
 
-    fn may_not_refer_to_existing_definition(&self) -> bool {
+    fn allow_invalid(&self) -> bool {
         match &self {
-            Self::WithReason {
-                may_not_refer_to_existing_definition,
-                ..
-            } => may_not_refer_to_existing_definition.unwrap_or_default(),
+            Self::WithReason { allow_invalid, .. } => allow_invalid.unwrap_or_default(),
             Self::Simple(_) => false,
         }
     }
@@ -181,7 +178,7 @@ pub fn create_disallowed_map<const REPLACEMENT_ALLOWED: bool>(
                     span,
                     format!("expected a {predicate_description}, found a primitive type",),
                 );
-            } else if !disallowed_path.may_not_refer_to_existing_definition {
+            } else if !disallowed_path.allow_invalid {
                 tcx.sess.dcx().span_warn(
                     span,
                     format!("`{path}` does not refer to an existing {predicate_description}"),

tests/ui-toml/toml_invalid_path/clippy.toml

@@ -11,4 +11,4 @@ path = "std::process::current_exe"
 
 [[disallowed-methods]]
 path = "std::current_exe"
-may-not-refer-to-existing-definition = true
+allow-invalid = true