Skip to content

Commit e33ab3f

Browse files
committed
Add test for needless_return lint
1 parent 91292f1 commit e33ab3f

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

tests/ui/needless_return.fixed

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,12 @@ mod issue6501 {
112112
};
113113
let _ = || {};
114114
}
115+
116+
struct Foo;
117+
#[allow(clippy::unnecessary_lazy_evaluations)]
118+
fn bar(res: Result<Foo, u8>) -> Foo {
119+
res.unwrap_or_else(|_| Foo)
120+
}
115121
}
116122

117123
fn main() {

tests/ui/needless_return.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,12 @@ mod issue6501 {
112112
};
113113
let _ = || return;
114114
}
115+
116+
struct Foo;
117+
#[allow(clippy::unnecessary_lazy_evaluations)]
118+
fn bar(res: Result<Foo, u8>) -> Foo {
119+
res.unwrap_or_else(|_| return Foo)
120+
}
115121
}
116122

117123
fn main() {

tests/ui/needless_return.stderr

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,5 +102,11 @@ error: unneeded `return` statement
102102
LL | let _ = || return;
103103
| ^^^^^^ help: replace `return` with an empty block: `{}`
104104

105-
error: aborting due to 17 previous errors
105+
error: unneeded `return` statement
106+
--> $DIR/needless_return.rs:119:32
107+
|
108+
LL | res.unwrap_or_else(|_| return Foo)
109+
| ^^^^^^^^^^ help: remove `return`: `Foo`
110+
111+
error: aborting due to 18 previous errors
106112

0 commit comments

Comments
 (0)