Move uninlined_format_args to style

nyurik · nyurik · commit d063e09d1025 · 2025-03-25T10:27:20.000-04:00
This lint was downgraded to `pedantic` in part because rust-analyzer was not fully supporting it at the time per #10087. The support has been added over [a year ago](rust-lang/rust-analyzer#11260), so seems like this should be back to style. Another source of the initial frustration was fixed since then as well - this lint does not trigger by default in case only some arguments can be inlined.
diff --git a/tests/ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.fixed b/tests/ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.fixed
@@ -1,5 +1,5 @@
 #![deny(clippy::index_refutable_slice)]
-
+#![allow(clippy::uninlined_format_args)]
 fn below_limit() {
     let slice: Option<&[u32]> = Some(&[1, 2, 3]);
     if let Some([_, _, _, _, _, _, _, slice_7, ..]) = slice {
diff --git a/tests/ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs b/tests/ui-toml/max_suggested_slice_pattern_length/index_refutable_slice.rs
@@ -1,5 +1,5 @@
 #![deny(clippy::index_refutable_slice)]
-
+#![allow(clippy::uninlined_format_args)]
 fn below_limit() {
     let slice: Option<&[u32]> = Some(&[1, 2, 3]);
     if let Some(slice) = slice {
diff --git a/tests/ui/author/macro_in_closure.rs b/tests/ui/author/macro_in_closure.rs
@@ -1,4 +1,5 @@
 //@ check-pass
+#![allow(clippy::uninlined_format_args)]
 
 fn main() {
     #[clippy::author]
diff --git a/tests/ui/author/macro_in_loop.rs b/tests/ui/author/macro_in_loop.rs
@@ -1,6 +1,7 @@
 //@ check-pass
 
 #![feature(stmt_expr_attributes)]
+#![allow(clippy::uninlined_format_args)]
 
 fn main() {
     #[clippy::author]
diff --git a/tests/ui/dbg_macro/dbg_macro.fixed b/tests/ui/dbg_macro/dbg_macro.fixed
@@ -1,6 +1,6 @@
 #![warn(clippy::dbg_macro)]
 #![allow(clippy::unnecessary_operation, clippy::no_effect, clippy::unit_arg)]
-
+#![allow(clippy::uninlined_format_args)]
 fn foo(n: u32) -> u32 {
     if let Some(n) = n.checked_sub(4) { n } else { n }
     //~^ dbg_macro
diff --git a/tests/ui/dbg_macro/dbg_macro.rs b/tests/ui/dbg_macro/dbg_macro.rs
@@ -1,6 +1,6 @@
 #![warn(clippy::dbg_macro)]
 #![allow(clippy::unnecessary_operation, clippy::no_effect, clippy::unit_arg)]
-
+#![allow(clippy::uninlined_format_args)]
 fn foo(n: u32) -> u32 {
     if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
     //~^ dbg_macro
diff --git a/tests/ui/large_futures.fixed b/tests/ui/large_futures.fixed
@@ -1,7 +1,7 @@
 #![warn(clippy::large_futures)]
 #![allow(clippy::never_loop)]
 #![allow(clippy::future_not_send)]
-#![allow(clippy::manual_async_fn)]
+#![allow(clippy::manual_async_fn, clippy::uninlined_format_args)]
 
 async fn big_fut(_arg: [u8; 1024 * 16]) {}
 
diff --git a/tests/ui/large_futures.rs b/tests/ui/large_futures.rs
@@ -1,7 +1,7 @@
 #![warn(clippy::large_futures)]
 #![allow(clippy::never_loop)]
 #![allow(clippy::future_not_send)]
-#![allow(clippy::manual_async_fn)]
+#![allow(clippy::manual_async_fn, clippy::uninlined_format_args)]
 
 async fn big_fut(_arg: [u8; 1024 * 16]) {}
 
diff --git a/tests/ui/manual_inspect.fixed b/tests/ui/manual_inspect.fixed
@@ -1,5 +1,5 @@
 #![warn(clippy::manual_inspect)]
-#![allow(clippy::no_effect, clippy::op_ref)]
+#![allow(clippy::no_effect, clippy::op_ref, clippy::uninlined_format_args)]
 
 fn main() {
     let _ = Some(0).inspect(|&x| {
diff --git a/tests/ui/manual_inspect.rs b/tests/ui/manual_inspect.rs
@@ -1,5 +1,5 @@
 #![warn(clippy::manual_inspect)]
-#![allow(clippy::no_effect, clippy::op_ref)]
+#![allow(clippy::no_effect, clippy::op_ref, clippy::uninlined_format_args)]
 
 fn main() {
     let _ = Some(0).map(|x| {
diff --git a/tests/ui/needless_pass_by_ref_mut.rs b/tests/ui/needless_pass_by_ref_mut.rs
@@ -1,13 +1,13 @@
 #![allow(
     clippy::if_same_then_else,
     clippy::no_effect,
+    clippy::ptr_arg,
     clippy::redundant_closure_call,
-    clippy::ptr_arg
+    clippy::uninlined_format_args
 )]
 #![warn(clippy::needless_pass_by_ref_mut)]
 //@no-rustfix
 use std::ptr::NonNull;
-
 fn foo(s: &mut Vec<u32>, b: &u32, x: &mut u32) {
     //~^ needless_pass_by_ref_mut
 
diff --git a/tests/ui/to_string_in_format_args_incremental.fixed b/tests/ui/to_string_in_format_args_incremental.fixed
@@ -1,5 +1,5 @@
 //@compile-flags: -C incremental=target/debug/test/incr
-
+#![allow(clippy::uninlined_format_args)]
 // see https://github.com/rust-lang/rust-clippy/issues/10969
 
 fn main() {
diff --git a/tests/ui/to_string_in_format_args_incremental.rs b/tests/ui/to_string_in_format_args_incremental.rs
@@ -1,5 +1,5 @@
 //@compile-flags: -C incremental=target/debug/test/incr
-
+#![allow(clippy::uninlined_format_args)]
 // see https://github.com/rust-lang/rust-clippy/issues/10969
 
 fn main() {
diff --git a/tests/ui/unnecessary_iter_cloned.fixed b/tests/ui/unnecessary_iter_cloned.fixed
@@ -1,4 +1,4 @@
-#![allow(unused_assignments)]
+#![allow(unused_assignments, clippy::uninlined_format_args)]
 #![warn(clippy::unnecessary_to_owned)]
 
 #[allow(dead_code)]
diff --git a/tests/ui/unnecessary_iter_cloned.rs b/tests/ui/unnecessary_iter_cloned.rs
@@ -1,4 +1,4 @@
-#![allow(unused_assignments)]
+#![allow(unused_assignments, clippy::uninlined_format_args)]
 #![warn(clippy::unnecessary_to_owned)]
 
 #[allow(dead_code)]
diff --git a/tests/ui/unnecessary_operation.fixed b/tests/ui/unnecessary_operation.fixed
@@ -6,7 +6,7 @@
     clippy::unnecessary_struct_initialization
 )]
 #![warn(clippy::unnecessary_operation)]
-
+#![allow(clippy::uninlined_format_args)]
 use std::fmt::Display;
 use std::ops::Shl;
 
diff --git a/tests/ui/unnecessary_operation.rs b/tests/ui/unnecessary_operation.rs
@@ -6,7 +6,7 @@
     clippy::unnecessary_struct_initialization
 )]
 #![warn(clippy::unnecessary_operation)]
-
+#![allow(clippy::uninlined_format_args)]
 use std::fmt::Display;
 use std::ops::Shl;
 
diff --git a/tests/ui/unnecessary_to_owned.fixed b/tests/ui/unnecessary_to_owned.fixed
@@ -7,7 +7,7 @@
     clippy::owned_cow
 )]
 #![warn(clippy::unnecessary_to_owned, clippy::redundant_clone)]
-
+#![allow(clippy::uninlined_format_args)]
 use std::borrow::Cow;
 use std::ffi::{CStr, CString, OsStr, OsString};
 use std::ops::Deref;
diff --git a/tests/ui/unnecessary_to_owned.rs b/tests/ui/unnecessary_to_owned.rs
@@ -7,7 +7,7 @@
     clippy::owned_cow
 )]
 #![warn(clippy::unnecessary_to_owned, clippy::redundant_clone)]
-
+#![allow(clippy::uninlined_format_args)]
 use std::borrow::Cow;
 use std::ffi::{CStr, CString, OsStr, OsString};
 use std::ops::Deref;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`//@ check-pass`
	`2`	`+#![allow(clippy::uninlined_format_args)]`
`2`	`3`
`3`	`4`	`fn main() {`
`4`	`5`	`#[clippy::author]`