why was i doing that manually?

Author: Centri3

clippy_lints/src/excessive_indentation.rs

@@ -1,9 +1,8 @@
 use clippy_utils::diagnostics::span_lint_and_help;
 use rustc_ast::{
-    ast::{ItemKind, UseTree, UseTreeKind},
-    Item,
+    visit::{walk_item, Visitor},
+    *,
 };
-use rustc_hir::*;
 use rustc_lint::{EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintContext};
 use rustc_middle::lint::in_external_macro;
 use rustc_session::{declare_tool_lint, impl_lint_pass};
@@ -64,77 +63,70 @@ pub struct ExcessiveIndentation {
 impl EarlyLintPass for ExcessiveIndentation {
     fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
         match &item.kind {
-            // TODO:
-            // Use        ✅
-            // Static     ❌
-            // Const      ❌
-            // Fn         ❌
-            // Mod        ❌
-            // ForeignMod ❌
-            // Enum       ❌
-            // Struct     ❌
-            // Union      ❌
-            // Trait      ❌
-            // Impl       ❌
-            // MacroDef   ❓
-            // Others don't increase indentation (unless your formatting is really weird) so they won't be included.
-            ItemKind::Use(use_tree) => walk_use_tree(self, cx, use_tree, 0),
             _ => (),
         }
     }
 }
 
-fn check_indent(conf: &mut ExcessiveIndentation, cx: &EarlyContext<'_>, span: Span, indent: u64) -> bool {
-    if indent > conf.excessive_indentation_threshold {
-        span_lint_and_help(cx, EXCESSIVE_INDENTATION, span, "a", None, "b");
-
-        return true;
-    }
-
-    false
+struct IndentationVisitor {
+    indent: u64,
 }
 
-fn walk_use_tree(conf: &mut ExcessiveIndentation, cx: &EarlyContext<'_>, use_tree: &UseTree, indent: u64) {
-    if check_indent(conf, cx, use_tree.span, indent) {
-        return;
-    }
-
-    if let UseTreeKind::Nested(use_trees) = use_tree.kind.clone() {
-        for use_tree in use_trees {
-            walk_use_tree(conf, cx, &use_tree.0, indent + 1);
-        }
-    }
-}
-
-impl LateLintPass<'_> for ExcessiveIndentation {
-    fn check_stmt(&mut self, cx: &LateContext<'_>, stmt: &Stmt<'_>) {
-        if in_external_macro(cx.sess(), stmt.span) {
-            return;
-        }
-
-        if let Ok(lines) = cx.sess().source_map().span_to_lines(stmt.span).map(|info| info.lines) {
-            for line in &lines {
-                let indentation = if self.excessive_width_ignore_indentation {
-                    line.start_col
-                } else {
-                    CharPos::from_usize(0)
-                };
-
-                // TODO: yeah, no.
-                if (line.end_col.to_usize()
-                    - line.start_col.to_usize() * self.excessive_width_ignore_indentation as usize)
-                    > self.excessive_width_threshold as usize
-                {
-                    span_lint_and_help(
-                        cx,
-                        EXCESSIVE_WIDTH,
-                        stmt.span,
-                        "this line is too long",
-                        None,
-                        "consider running rustfmt or refactoring this",
-                    );
-                }
+impl Visitor<'_> for IndentationVisitor {
+    fn visit_crate(&mut self, krate: &Crate) {
+        for item in krate.items {
+            match item.kind {
+                // TODO:
+                // Use        ✅
+                // Static     ❌
+                // Const      ❌
+                // Fn         ❌
+                // Mod        ❌
+                // ForeignMod ❌
+                // Enum       ❌
+                // Struct     ❌
+                // Union      ❌
+                // Trait      ❌
+                // Impl       ❌
+                // MacroDef   ❓
+                // Others don't increase indentation (unless your formatting is really weird) so they won't be included.
+                ItemKind::Use(use_tree) => todo!(),
+                _ => (),
             }
         }
     }
 }
+
+// impl LateLintPass<'_> for ExcessiveIndentation {
+//     fn check_stmt(&mut self, cx: &LateContext<'_>, stmt: &Stmt<'_>) {
+//         if in_external_macro(cx.sess(), stmt.span) {
+//             return;
+//         }
+//
+//         if let Ok(lines) = cx.sess().source_map().span_to_lines(stmt.span).map(|info| info.lines)
+// {             for line in &lines {
+//                 let indentation = if self.excessive_width_ignore_indentation {
+//                     line.start_col
+//                 } else {
+//                     CharPos::from_usize(0)
+//                 };
+//
+//                 // TODO: yeah, no.
+//                 if (line.end_col.to_usize()
+//                     - line.start_col.to_usize() * self.excessive_width_ignore_indentation as
+//                       usize)
+//                     > self.excessive_width_threshold as usize
+//                 {
+//                     span_lint_and_help(
+//                         cx,
+//                         EXCESSIVE_WIDTH,
+//                         stmt.span,
+//                         "this line is too long",
+//                         None,
+//                         "consider running rustfmt or refactoring this",
+//                     );
+//                 }
+//             }
+//         }
+//     }
+// }