Renamed to explicit_deref_method and move to pedantic

Author: tommilligan

clippy_lints/src/dereference.rs

@@ -1,8 +1,8 @@
 use crate::rustc::hir::{Expr, ExprKind, QPath};
 use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
 use crate::rustc::{declare_tool_lint, lint_array};
-use if_chain::if_chain;
 use crate::utils::span_lint_and_sugg;
+use if_chain::if_chain;
 
 /// **What it does:** Checks for explicit deref() or deref_mut() method calls.
 ///
@@ -19,16 +19,16 @@ use crate::utils::span_lint_and_sugg;
 /// let f = a.deref().unwrap();
 /// ```
 declare_clippy_lint! {
-    pub DEREF_METHOD_EXPLICIT,
-    complexity,
+    pub EXPLICIT_DEREF_METHOD,
+    pedantic,
     "Explicit use of deref or deref_mut method while not in a method chain."
 }
 
 pub struct Pass;
 
 impl LintPass for Pass {
     fn get_lints(&self) -> LintArray {
-        lint_array!(DEREF_METHOD_EXPLICIT)
+        lint_array!(EXPLICIT_DEREF_METHOD)
     }
 }
 
@@ -46,7 +46,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
                     "deref" => {
                         span_lint_and_sugg(
                             cx,
-                            DEREF_METHOD_EXPLICIT,
+                            EXPLICIT_DEREF_METHOD,
                             expr.span,
                             "explicit deref method call",
                             "try this",
@@ -56,7 +56,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
                     "deref_mut" => {
                         span_lint_and_sugg(
                             cx,
-                            DEREF_METHOD_EXPLICIT,
+                            EXPLICIT_DEREF_METHOD,
                             expr.span,
                             "explicit deref_mut method call",
                             "try this",

clippy_lints/src/lib.rs

@@ -1062,6 +1062,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(&copies::SAME_FUNCTIONS_IN_IF_CONDITION),
         LintId::of(&copy_iterator::COPY_ITERATOR),
         LintId::of(&default_trait_access::DEFAULT_TRAIT_ACCESS),
+        LintId::of(&dereference::EXPLICIT_DEREF_METHOD),
         LintId::of(&derive::EXPL_IMPL_CLONE_ON_COPY),
         LintId::of(&doc::DOC_MARKDOWN),
         LintId::of(&doc::MISSING_ERRORS_DOC),
@@ -1146,7 +1147,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(&comparison_chain::COMPARISON_CHAIN),
         LintId::of(&copies::IFS_SAME_COND),
         LintId::of(&copies::IF_SAME_THEN_ELSE),
-        LintId::of(&dereference::DEREF_METHOD_EXPLICIT),
+        LintId::of(&dereference::EXPLICIT_DEREF_METHOD),
         LintId::of(&derive::DERIVE_HASH_XOR_EQ),
         LintId::of(&doc::MISSING_SAFETY_DOC),
         LintId::of(&doc::NEEDLESS_DOCTEST_MAIN),

tests/ui/dereference.rs

@@ -4,7 +4,7 @@ use std::ops::{Deref, DerefMut};
 
 #[allow(clippy::many_single_char_names, clippy::clone_double_ref)]
 #[allow(unused_variables)]
-#[warn(clippy::deref_method_explicit)]
+#[warn(clippy::explicit_deref_method)]
 fn main() {
     let a: &mut String = &mut String::from("foo");
 

tests/ui/dereference.stderr

@@ -4,7 +4,7 @@ error: explicit deref method call
 13 |         let b: &str = a.deref();
    |                       ^^^^^^^^^ help: try this: `&*a`
    |
-   = note: `-D clippy::deref-method-explicit` implied by `-D warnings`
+   = note: `-D clippy::explicit-deref-method` implied by `-D warnings`
 
 error: explicit deref_mut method call
   --> $DIR/dereference.rs:17:27