msg

Author: lengyijun

clippy_lints/src/needless_deref.rs

@@ -12,8 +12,10 @@ declare_clippy_lint! {
     /// Checks for `&*(&T)`.
     ///
     /// ### Why is this bad?
-    /// If you just want to reborrow, `&T` is enough (`&T` is Copy).
+    /// When people deref on an immutable reference `&T`, they may expect return `&U`.
+    /// Accutually `&* (&T)` is still `&T`.
     /// if you want to deref explicitly, `&** (&T)` is what you need.
+    /// If you want to reborrow, `&T` is enough (`&T` is Copy).
     ///
     /// ### Known problems
     /// None.
@@ -34,7 +36,7 @@ declare_clippy_lint! {
     /// ```
     pub NEEDLESS_DEREF,
     complexity,
-    "remove needless deref"
+    "deref on an immutable reference returns the same type as itself"
 }
 
 declare_lint_pass!(NeedlessDeref => [NEEDLESS_DEREF]);
@@ -69,7 +71,7 @@ impl LateLintPass<'_> for NeedlessDeref {
                     cx,
                     NEEDLESS_DEREF,
                     e.span,
-                    "reference on a de-referenced",
+                    "deref on an immutable borrow",
                     None,
                     &format!(
                         "consider using `{}` if you would like to deref\nconsider using `{}` if you would like to reborrow",

tests/ui/needless_deref.stderr

@@ -1,4 +1,4 @@
-error: reference on a de-referenced
+error: deref on an immutable borrow
   --> $DIR/needless_deref.rs:6:18
    |
 LL |         let _b = &*a;
@@ -8,7 +8,7 @@ LL |         let _b = &*a;
    = help: consider using `&**a` if you would like to deref
            consider using `a` if you would like to reborrow
 
-error: reference on a de-referenced
+error: deref on an immutable borrow
   --> $DIR/needless_deref.rs:9:23
    |
 LL |         let a: &str = &*s;