inline suggestion and use path.ident.name instead of snippet

Author: jonboh

clippy_lints/src/unnecessary_map_on_constructor.rs

@@ -75,19 +75,17 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryMapOnConstructor {
                 if let hir::ExprKind::Path(fun) = arg.kind;
                 then {
                     let mut applicability = Applicability::MachineApplicable;
-                    let fun_snippet = snippet_with_applicability(cx, fun.span(), "_", &mut applicability);
                     let constructor_snippet =
                         snippet_with_applicability(cx, constructor_path.span(), "_", &mut applicability);
                     let constructor_arg_snippet =
                         snippet_with_applicability(cx, constructor_item.span, "_", &mut applicability);
-                    let suggestion = format!("{constructor_snippet}({fun_snippet}({constructor_arg_snippet}))");
                     span_lint_and_sugg(
                         cx,
                         UNNECESSARY_MAP_ON_CONSTRUCTOR,
                         expr.span,
-                        &format!("unnecessary {fun_snippet} on contstuctor {constructor_snippet}(_)"),
-                        "try using",
-                        suggestion,
+                        &format!("unnecessary {} on contstuctor {constructor_snippet}(_)", path.ident.name),
+                        "try",
+                        format!("{constructor_snippet}({}({constructor_arg_snippet}))", path.ident.name),
                         applicability,
                     );
                 }