Skip to content

Commit 1b117f4

Browse files
pitiK3Uflip1995
authored andcommitted
Add tests for from_iter_instead_of_collect
1 parent 9d6eedf commit 1b117f4

File tree

3 files changed

+34
-0
lines changed

3 files changed

+34
-0
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
#![warn(clippy::from_iter_instead_of_collect)]
2+
3+
use std::collections::HashMap;
4+
use std::iter::FromIterator;
5+
6+
fn main() {
7+
{
8+
let iter_expr = std::iter::repeat(5).take(5);
9+
10+
Vec::from_iter(iter_expr);
11+
HashMap::<usize, &i8>::from_iter(vec![5, 5, 5, 5].iter().enumerate());
12+
//let v: Vec<i32> = iter_expr.collect();
13+
let a: Vec<i32> = Vec::new();
14+
}
15+
}
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
error: use `.collect()` instead of `::from_iter()`
2+
--> $DIR/from_iter_instead_of_collect.rs:10:5
3+
|
4+
LL | Vec::from_iter(iter_expr);
5+
| ^^^^^^^^^^^^^^^^^^^^^^^^^
6+
|
7+
= note: `-D clippy::from-iter-instead-of-collect` implied by `-D warnings`
8+
= help: consider using `iter_expr.collect()`
9+
10+
error: use `.collect()` instead of `::from_iter()`
11+
--> $DIR/from_iter_instead_of_collect.rs:11:5
12+
|
13+
LL | HashMap::<usize, &i8>::from_iter(vec![5,5,5,5].iter().enumerate());
14+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
15+
|
16+
= help: consider using `vec![5,5,5,5].iter().enumerate().collect()`
17+
18+
error: aborting due to 2 previous errors
19+

tests/ui/from_iter_instead_of_collect.stdout

Whitespace-only changes.

0 commit comments

Comments
 (0)