don't auto fix

Author: lengyijun

clippy_lints/src/needless_deref.rs

@@ -1,8 +1,6 @@
-use clippy_utils::diagnostics::span_lint_and_sugg;
+use clippy_utils::diagnostics::span_lint_and_help;
 use clippy_utils::in_macro;
 use clippy_utils::source::snippet_opt;
-use clippy_utils::source::snippet_with_applicability;
-use rustc_errors::Applicability;
 use rustc_hir::ExprKind;
 use rustc_hir::UnOp;
 use rustc_lint::{LateContext, LateLintPass};
@@ -69,29 +67,18 @@ impl LateLintPass<'_> for NeedlessDeref {
                 }
 
 
-                let outer_ty=cx.typeck_results().expr_ty(e);
-                let mut applicability = Applicability::MachineApplicable;
-                if inner_ty == outer_ty {
-                    span_lint_and_sugg(
-                        cx,
-                        NEEDLESS_DEREF,
-                        e.span,
-                        "immediately dereferencing a reference",
-                        "try this",
-                        snippet_with_applicability(cx, deref_target.span, "_", &mut applicability).to_string(),
-                        applicability,
-                    );
-                }else{
-                    span_lint_and_sugg(
-                        cx,
-                        NEEDLESS_DEREF,
-                        e.span,
-                        "reference on a de-referenced",
-                        "you may want to do this",
+                span_lint_and_help(
+                    cx,
+                    NEEDLESS_DEREF,
+                    e.span,
+                    "reference on a de-referenced",
+                    None,
+                    &format!(
+                        "consider using `{}` if you would like to deref\nconsider using `{}` if you would like to reborrow",
                         "&**".to_owned()+&snippet_opt(cx, deref_target.span).unwrap(),
-                        Applicability::MachineApplicable,
-                    );
-                }
+                        &snippet_opt(cx, deref_target.span).unwrap(),
+                     )
+                );
             }
         }
     }

tests/ui/needless_deref.stderr

@@ -1,10 +1,12 @@
-error: immediately dereferencing a reference
+error: reference on a de-referenced
   --> $DIR/needless_deref.rs:6:18
    |
 LL |         let _b = &*a;
-   |                  ^^^ help: try this: `a`
+   |                  ^^^
    |
    = note: `-D clippy::needless-deref` implied by `-D warnings`
+   = help: consider using `&**a` if you would like to deref
+           consider using `a` if you would like to reborrow
 
 error: aborting due to previous error