Also allow renaming to underscore

detrumi · detrumi · commit f081c9d94dcc · 2019-11-29T15:27:22.000+01:00
diff --git a/crates/ra_lsp_server/src/main_loop/handlers.rs b/crates/ra_lsp_server/src/main_loop/handlers.rs
@@ -508,7 +508,9 @@ pub fn handle_rename(world: WorldSnapshot, params: RenameParams) -> Result<Optio
 
     // Only rename to valid identifiers
     let tokens = tokenize(&params.new_name);
-    if tokens.len() != 1 || tokens[0].kind != SyntaxKind::IDENT {
+    if tokens.len() != 1
+        || (tokens[0].kind != SyntaxKind::IDENT && tokens[0].kind != SyntaxKind::UNDERSCORE)
+    {
         return Ok(None);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,9 @@ pub fn handle_rename(world: WorldSnapshot, params: RenameParams) -> Result<Optio`
`508`	`508`
`509`	`509`	`// Only rename to valid identifiers`
`510`	`510`	`let tokens = tokenize(&params.new_name);`
`511`		`- if tokens.len() != 1 \|\| tokens[0].kind != SyntaxKind::IDENT {`
	`511`	`+ if tokens.len() != 1`
	`512`	`+ \|\| (tokens[0].kind != SyntaxKind::IDENT && tokens[0].kind != SyntaxKind::UNDERSCORE)`
	`513`	`+ {`
`512`	`514`	`return Ok(None);`
`513`	`515`	`}`
`514`	`516`