Skip to content

Commit e63c00f

Browse files
committed
Rename resolve_relative_path -> resolve_path
For things like `concant!(env!("OUT_DIR"))`, we need to support abs paths
1 parent f98d057 commit e63c00f

File tree

7 files changed

+12
-33
lines changed

7 files changed

+12
-33
lines changed

crates/ra_db/src/lib.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ pub const DEFAULT_LRU_CAP: usize = 128;
8989
pub trait FileLoader {
9090
/// Text of the file.
9191
fn file_text(&self, file_id: FileId) -> Arc<String>;
92-
fn resolve_relative_path(&self, anchor: FileId, relative_path: &RelativePath)
93-
-> Option<FileId>;
92+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId>;
9493
fn relevant_crates(&self, file_id: FileId) -> Arc<Vec<CrateId>>;
9594

9695
fn resolve_extern_path(
@@ -155,11 +154,7 @@ impl<T: SourceDatabaseExt> FileLoader for FileLoaderDelegate<&'_ T> {
155154
fn file_text(&self, file_id: FileId) -> Arc<String> {
156155
SourceDatabaseExt::file_text(self.0, file_id)
157156
}
158-
fn resolve_relative_path(
159-
&self,
160-
anchor: FileId,
161-
relative_path: &RelativePath,
162-
) -> Option<FileId> {
157+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId> {
163158
let path = {
164159
let mut path = self.0.file_relative_path(anchor);
165160
assert!(path.pop());

crates/ra_hir_def/src/nameres/mod_resolution.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ impl ModDir {
6161
};
6262

6363
for candidate in candidate_files.iter() {
64-
if let Some(file_id) = db.resolve_relative_path(file_id, candidate) {
64+
if let Some(file_id) = db.resolve_path(file_id, candidate) {
6565
let mut root_non_dir_owner = false;
6666
let mut mod_path = RelativePathBuf::new();
6767
if !(candidate.ends_with("mod.rs") || attr_path.is_some()) {

crates/ra_hir_def/src/test_db.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,8 @@ impl FileLoader for TestDB {
5858
fn file_text(&self, file_id: FileId) -> Arc<String> {
5959
FileLoaderDelegate(self).file_text(file_id)
6060
}
61-
fn resolve_relative_path(
62-
&self,
63-
anchor: FileId,
64-
relative_path: &RelativePath,
65-
) -> Option<FileId> {
66-
FileLoaderDelegate(self).resolve_relative_path(anchor, relative_path)
61+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId> {
62+
FileLoaderDelegate(self).resolve_path(anchor, relative_path)
6763
}
6864
fn relevant_crates(&self, file_id: FileId) -> Arc<Vec<CrateId>> {
6965
FileLoaderDelegate(self).relevant_crates(file_id)

crates/ra_hir_expand/src/builtin_macro.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ fn relative_file(db: &dyn AstDatabase, call_id: MacroCallId, path: &str) -> Opti
297297
let call_site = call_id.as_file().original_file(db);
298298

299299
// Handle trivial case
300-
if let Some(res) = db.resolve_relative_path(call_site, &RelativePath::new(&path)) {
300+
if let Some(res) = db.resolve_path(call_site, &RelativePath::new(&path)) {
301301
// Prevent include itself
302302
return if res == call_site { None } else { Some(res) };
303303
}

crates/ra_hir_expand/src/test_db.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@ impl FileLoader for TestDB {
4141
fn file_text(&self, file_id: FileId) -> Arc<String> {
4242
FileLoaderDelegate(self).file_text(file_id)
4343
}
44-
fn resolve_relative_path(
45-
&self,
46-
anchor: FileId,
47-
relative_path: &RelativePath,
48-
) -> Option<FileId> {
49-
FileLoaderDelegate(self).resolve_relative_path(anchor, relative_path)
44+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId> {
45+
FileLoaderDelegate(self).resolve_path(anchor, relative_path)
5046
}
5147
fn relevant_crates(&self, file_id: FileId) -> Arc<Vec<CrateId>> {
5248
FileLoaderDelegate(self).relevant_crates(file_id)

crates/ra_hir_ty/src/test_db.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,8 @@ impl FileLoader for TestDB {
7272
fn file_text(&self, file_id: FileId) -> Arc<String> {
7373
FileLoaderDelegate(self).file_text(file_id)
7474
}
75-
fn resolve_relative_path(
76-
&self,
77-
anchor: FileId,
78-
relative_path: &RelativePath,
79-
) -> Option<FileId> {
80-
FileLoaderDelegate(self).resolve_relative_path(anchor, relative_path)
75+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId> {
76+
FileLoaderDelegate(self).resolve_path(anchor, relative_path)
8177
}
8278
fn relevant_crates(&self, file_id: FileId) -> Arc<Vec<CrateId>> {
8379
FileLoaderDelegate(self).relevant_crates(file_id)

crates/ra_ide_db/src/lib.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,8 @@ impl FileLoader for RootDatabase {
5757
fn file_text(&self, file_id: FileId) -> Arc<String> {
5858
FileLoaderDelegate(self).file_text(file_id)
5959
}
60-
fn resolve_relative_path(
61-
&self,
62-
anchor: FileId,
63-
relative_path: &RelativePath,
64-
) -> Option<FileId> {
65-
FileLoaderDelegate(self).resolve_relative_path(anchor, relative_path)
60+
fn resolve_path(&self, anchor: FileId, relative_path: &RelativePath) -> Option<FileId> {
61+
FileLoaderDelegate(self).resolve_path(anchor, relative_path)
6662
}
6763
fn relevant_crates(&self, file_id: FileId) -> Arc<Vec<CrateId>> {
6864
FileLoaderDelegate(self).relevant_crates(file_id)

0 commit comments

Comments
 (0)