Prevent renaming SelfType and BuiltinType

Veykril · Veykril · commit e194f2edc427 · 2021-03-03T19:48:53.000+01:00
diff --git a/crates/ide/src/references/rename.rs b/crates/ide/src/references/rename.rs
@@ -88,6 +88,8 @@ pub(crate) fn rename_with_semantics(
     let def = find_definition(sema, syntax, position)?;
     match def {
         Definition::ModuleDef(ModuleDef::Module(module)) => rename_mod(&sema, module, new_name),
+        Definition::SelfType(_) => bail!("Cannot rename `Self`"),
+        Definition::ModuleDef(ModuleDef::BuiltinType(_)) => bail!("Cannot rename builtin type"),
         def => rename_reference(sema, def, new_name),
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,8 @@ pub(crate) fn rename_with_semantics(`
`88`	`88`	`let def = find_definition(sema, syntax, position)?;`
`89`	`89`	`match def {`
`90`	`90`	`Definition::ModuleDef(ModuleDef::Module(module)) => rename_mod(&sema, module, new_name),`
	`91`	+ Definition::SelfType(_) => bail!("Cannot rename `Self`"),
	`92`	`+ Definition::ModuleDef(ModuleDef::BuiltinType(_)) => bail!("Cannot rename builtin type"),`
`91`	`93`	`def => rename_reference(sema, def, new_name),`
`92`	`94`	`}`
`93`	`95`	`}`