Skip to content

Commit d652e1e

Browse files
Merge #2422
2422: Use a simple progress bar instead of indicatif r=maklad a=edwin0cheng ![pb](https://user-images.githubusercontent.com/11014119/69669230-6a3d5a80-10cc-11ea-8ad7-4dccb10349c9.gif) Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2 parents 7d088a1 + f0aaf3b commit d652e1e

File tree

5 files changed

+125
-37
lines changed

5 files changed

+125
-37
lines changed

Cargo.lock

Lines changed: 0 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/ra_cli/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ publish = false
88
[dependencies]
99
pico-args = "0.3.0"
1010
flexi_logger = "0.14.0"
11-
indicatif = "0.13.0"
1211

1312
ra_syntax = { path = "../ra_syntax" }
1413
ra_ide_api = { path = "../ra_ide_api" }

crates/ra_cli/src/analysis_stats.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use ra_db::SourceDatabaseExt;
66
use ra_hir::{AssocItem, Crate, HasSource, HirDisplay, ModuleDef, Ty, TypeWalk};
77
use ra_syntax::AstNode;
88

9-
use crate::{Result, Verbosity};
9+
use crate::{progress_report::ProgressReport, Result, Verbosity};
1010

1111
pub fn run(
1212
verbosity: Verbosity,
@@ -75,17 +75,11 @@ pub fn run(
7575
println!("Item Collection: {:?}, {}", analysis_time.elapsed(), ra_prof::memory_usage());
7676

7777
let inference_time = Instant::now();
78-
let bar = match verbosity {
79-
Verbosity::Verbose | Verbosity::Normal => indicatif::ProgressBar::with_draw_target(
80-
funcs.len() as u64,
81-
indicatif::ProgressDrawTarget::stderr_nohz(),
82-
),
83-
Verbosity::Quiet => indicatif::ProgressBar::hidden(),
78+
let mut bar = match verbosity {
79+
Verbosity::Verbose | Verbosity::Normal => ProgressReport::new(funcs.len() as u64),
80+
Verbosity::Quiet => ProgressReport::hidden(),
8481
};
8582

86-
bar.set_style(
87-
indicatif::ProgressStyle::default_bar().template("{wide_bar} {pos}/{len}\n{msg}"),
88-
);
8983
bar.tick();
9084
let mut num_exprs = 0;
9185
let mut num_exprs_unknown = 0;

crates/ra_cli/src/main.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
mod analysis_stats;
44
mod analysis_bench;
55
mod help;
6+
mod progress_report;
67

78
use std::{error::Error, fmt::Write, io::Read};
89

crates/ra_cli/src/progress_report.rs

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
//! A simple progress bar
2+
//!
3+
//! A single thread non-optimized progress bar
4+
use std::io::Write;
5+
6+
/// A Simple ASCII Progress Bar
7+
pub struct ProgressReport {
8+
curr: f32,
9+
text: String,
10+
hidden: bool,
11+
12+
len: u64,
13+
pos: u64,
14+
msg: String,
15+
}
16+
17+
impl ProgressReport {
18+
pub fn new(len: u64) -> ProgressReport {
19+
ProgressReport {
20+
curr: 0.0,
21+
text: String::new(),
22+
hidden: false,
23+
len,
24+
pos: 0,
25+
msg: String::new(),
26+
}
27+
}
28+
29+
pub fn hidden() -> ProgressReport {
30+
ProgressReport {
31+
curr: 0.0,
32+
text: String::new(),
33+
hidden: true,
34+
len: 0,
35+
pos: 0,
36+
msg: String::new(),
37+
}
38+
}
39+
40+
pub fn set_message(&mut self, msg: &str) {
41+
self.msg = msg.to_string();
42+
self.tick();
43+
}
44+
45+
pub fn println<I: Into<String>>(&mut self, msg: I) {
46+
self.clear();
47+
println!("{}", msg.into());
48+
self.tick();
49+
}
50+
51+
pub fn inc(&mut self, delta: u64) {
52+
self.pos += delta;
53+
if self.len == 0 {
54+
self.set_value(0.0)
55+
} else {
56+
self.set_value((self.pos as f32) / (self.len as f32))
57+
}
58+
self.tick();
59+
}
60+
61+
pub fn finish_and_clear(&mut self) {
62+
self.clear();
63+
}
64+
65+
pub fn tick(&mut self) {
66+
if self.hidden {
67+
return;
68+
}
69+
let percent = (self.curr * 100.0) as u32;
70+
let text = format!("{}/{} {:3>}% {}", self.pos, self.len, percent, self.msg);
71+
self.update_text(&text);
72+
}
73+
74+
fn update_text(&mut self, text: &str) {
75+
// Get length of common portion
76+
let mut common_prefix_length = 0;
77+
let common_length = usize::min(self.text.len(), text.len());
78+
79+
while common_prefix_length < common_length
80+
&& text.chars().nth(common_prefix_length).unwrap()
81+
== self.text.chars().nth(common_prefix_length).unwrap()
82+
{
83+
common_prefix_length += 1;
84+
}
85+
86+
// Backtrack to the first differing character
87+
let mut output = String::new();
88+
output += &'\x08'.to_string().repeat(self.text.len() - common_prefix_length);
89+
// Output new suffix
90+
output += &text[common_prefix_length..text.len()];
91+
92+
// If the new text is shorter than the old one: delete overlapping characters
93+
if let Some(overlap_count) = self.text.len().checked_sub(text.len()) {
94+
if overlap_count > 0 {
95+
output += &" ".repeat(overlap_count);
96+
output += &"\x08".repeat(overlap_count);
97+
}
98+
}
99+
100+
let _ = std::io::stdout().write(output.as_bytes());
101+
let _ = std::io::stdout().flush();
102+
self.text = text.to_string();
103+
}
104+
105+
fn set_value(&mut self, value: f32) {
106+
self.curr = f32::max(0.0, f32::min(1.0, value));
107+
}
108+
109+
fn clear(&mut self) {
110+
if self.hidden {
111+
return;
112+
}
113+
114+
// Fill all last text to space and return the cursor
115+
let spaces = " ".repeat(self.text.len());
116+
let backspaces = "\x08".repeat(self.text.len());
117+
print!("{}{}{}", backspaces, spaces, backspaces);
118+
self.text = String::new();
119+
}
120+
}

0 commit comments

Comments
 (0)