Clarify when we visit modules multiple times

Jonas Schievink · Jonas Schievink · commit bc2d1729957a · 2020-06-05T14:24:51.000+02:00
diff --git a/crates/ra_hir_def/src/import_map.rs b/crates/ra_hir_def/src/import_map.rs
@@ -78,7 +78,9 @@ impl ImportMap {
                         }
                     }
 
-                    // If we've just added a path to a module, descend into it.
+                    // If we've just added a path to a module, descend into it. We might traverse
+                    // modules multiple times, but only if the new path to it is shorter than the
+                    // first (else we `continue` above).
                     if let Some(ModuleDefId::ModuleId(mod_id)) = item.as_module_def_id() {
                         worklist.push((mod_id, mk_path()));
                     }

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,9 @@ impl ImportMap {`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`- // If we've just added a path to a module, descend into it.`
	`81`	`+ // If we've just added a path to a module, descend into it. We might traverse`
	`82`	`+ // modules multiple times, but only if the new path to it is shorter than the`
	`83`	+ // first (else we `continue` above).
`82`	`84`	`if let Some(ModuleDefId::ModuleId(mod_id)) = item.as_module_def_id() {`
`83`	`85`	`worklist.push((mod_id, mk_path()));`
`84`	`86`	`}`