implement Literal::from_str

Anatol Ulrich · Anatol Ulrich · commit a6df2b16df47 · 2021-11-03T16:50:43.000+01:00
diff --git a/crates/proc_macro_srv/src/abis/abi_1_55/rustc_server.rs b/crates/proc_macro_srv/src/abis/abi_1_55/rustc_server.rs
@@ -488,8 +488,8 @@ impl server::Literal for Rustc {
         // They must still be present to be ABI-compatible and work with upstream proc_macro.
         "".to_owned()
     }
-    fn from_str(&mut self, _s: &str) -> Result<Self::Literal, ()> {
-        unimplemented!()
+    fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> {
+        Ok(Literal { text: s.into(), id: tt::TokenId::unspecified() })
     }
     fn symbol(&mut self, literal: &Self::Literal) -> String {
         literal.text.to_string()
diff --git a/crates/proc_macro_srv/src/abis/abi_1_56/rustc_server.rs b/crates/proc_macro_srv/src/abis/abi_1_56/rustc_server.rs
@@ -489,8 +489,8 @@ impl server::Literal for Rustc {
         // They must still be present to be ABI-compatible and work with upstream proc_macro.
         "".to_owned()
     }
-    fn from_str(&mut self, _s: &str) -> Result<Self::Literal, ()> {
-        unimplemented!()
+    fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> {
+        Ok(Literal { text: s.into(), id: tt::TokenId::unspecified() })
     }
     fn symbol(&mut self, literal: &Self::Literal) -> String {
         literal.text.to_string()

Original file line number	Diff line number	Diff line change
`@@ -488,8 +488,8 @@ impl server::Literal for Rustc {`
`488`	`488`	`// They must still be present to be ABI-compatible and work with upstream proc_macro.`
`489`	`489`	`"".to_owned()`
`490`	`490`	`}`
`491`		`- fn from_str(&mut self, _s: &str) -> Result<Self::Literal, ()> {`
`492`		`- unimplemented!()`
	`491`	`+ fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> {`
	`492`	`+ Ok(Literal { text: s.into(), id: tt::TokenId::unspecified() })`
`493`	`493`	`}`
`494`	`494`	`fn symbol(&mut self, literal: &Self::Literal) -> String {`
`495`	`495`	`literal.text.to_string()`
Original file line number	Diff line number	Diff line change
`@@ -489,8 +489,8 @@ impl server::Literal for Rustc {`
`489`	`489`	`// They must still be present to be ABI-compatible and work with upstream proc_macro.`
`490`	`490`	`"".to_owned()`
`491`	`491`	`}`
`492`		`- fn from_str(&mut self, _s: &str) -> Result<Self::Literal, ()> {`
`493`		`- unimplemented!()`
	`492`	`+ fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> {`
	`493`	`+ Ok(Literal { text: s.into(), id: tt::TokenId::unspecified() })`
`494`	`494`	`}`
`495`	`495`	`fn symbol(&mut self, literal: &Self::Literal) -> String {`
`496`	`496`	`literal.text.to_string()`