Skip to content

Commit a5f427c

Browse files
bors[bot]matklad
andauthored
Merge #4793
4793: Don't @ people in commit messages r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2 parents 3623c16 + 4968321 commit a5f427c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

docs/dev/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,14 @@ fn frobnicate(walrus: Option<Walrus>) {
261261
}
262262
```
263263

264+
## Commit Style
265+
266+
We don't have specific rules around git history hygiene.
267+
Maintaining clean git history is encouraged, but not enforced.
268+
We use rebase workflow, it's OK to rewrite history during PR review process.
269+
270+
Avoid @mentioning people in commit messages, as such messages create a lot of duplicate notification traffic during rebases.
271+
264272
# Architecture Invariants
265273

266274
This section tries to document high-level design constraints, which are not

0 commit comments

Comments
 (0)