feat: Implement inline_method assist

Author: Veykril

crates/ide_assists/src/handlers/early_return.rs

@@ -127,7 +127,7 @@ pub(crate) fn convert_to_guarded_return(acc: &mut Assists, ctx: &AssistContext)
                         let happy_arm = {
                             let pat = make::tuple_struct_pat(
                                 path,
-                                once(make::ident_pat(make::name("it")).into()),
+                                once(make::ext::simple_ident_pat(make::name("it")).into()),
                             );
                             let expr = {
                                 let path = make::ext::ident_path("it");

crates/ide_assists/src/handlers/extract_function.rs

@@ -341,9 +341,9 @@ impl Param {
         let var = self.var.name(ctx.db()).unwrap().to_string();
         let var_name = make::name(&var);
         let pat = match self.kind() {
-            ParamKind::MutValue => make::ident_mut_pat(var_name),
+            ParamKind::MutValue => make::ident_pat(false, true, var_name),
             ParamKind::Value | ParamKind::SharedRef | ParamKind::MutRef => {
-                make::ident_pat(var_name)
+                make::ext::simple_ident_pat(var_name)
             }
         };
 
@@ -1072,7 +1072,7 @@ impl FlowHandler {
             }
             FlowHandler::IfOption { action } => {
                 let path = make::ext::ident_path("Some");
-                let value_pat = make::ident_pat(make::name("value"));
+                let value_pat = make::ext::simple_ident_pat(make::name("value"));
                 let pattern = make::tuple_struct_pat(path, iter::once(value_pat.into()));
                 let cond = make::condition(call_expr, Some(pattern.into()));
                 let value = make::expr_path(make::ext::ident_path("value"));
@@ -1086,7 +1086,7 @@ impl FlowHandler {
 
                 let some_arm = {
                     let path = make::ext::ident_path("Some");
-                    let value_pat = make::ident_pat(make::name(some_name));
+                    let value_pat = make::ext::simple_ident_pat(make::name(some_name));
                     let pat = make::tuple_struct_pat(path, iter::once(value_pat.into()));
                     let value = make::expr_path(make::ext::ident_path(some_name));
                     make::match_arm(iter::once(pat.into()), None, value)
@@ -1105,14 +1105,14 @@ impl FlowHandler {
 
                 let ok_arm = {
                     let path = make::ext::ident_path("Ok");
-                    let value_pat = make::ident_pat(make::name(ok_name));
+                    let value_pat = make::ext::simple_ident_pat(make::name(ok_name));
                     let pat = make::tuple_struct_pat(path, iter::once(value_pat.into()));
                     let value = make::expr_path(make::ext::ident_path(ok_name));
                     make::match_arm(iter::once(pat.into()), None, value)
                 };
                 let err_arm = {
                     let path = make::ext::ident_path("Err");
-                    let value_pat = make::ident_pat(make::name(err_name));
+                    let value_pat = make::ext::simple_ident_pat(make::name(err_name));
                     let pat = make::tuple_struct_pat(path, iter::once(value_pat.into()));
                     let value = make::expr_path(make::ext::ident_path(err_name));
                     make::match_arm(

crates/ide_assists/src/handlers/fill_match_arms.rs

@@ -262,8 +262,9 @@ fn build_pat(db: &RootDatabase, module: hir::Module, var: ExtendedVariant) -> Op
                     make::tuple_struct_pat(path, pats).into()
                 }
                 ast::StructKind::Record(field_list) => {
-                    let pats =
-                        field_list.fields().map(|f| make::ident_pat(f.name().unwrap()).into());
+                    let pats = field_list
+                        .fields()
+                        .map(|f| make::ext::simple_ident_pat(f.name().unwrap()).into());
                     make::record_pat(path, pats).into()
                 }
                 ast::StructKind::Unit => make::path_pat(path),

crates/ide_assists/src/handlers/generate_function.rs

@@ -256,10 +256,9 @@ fn fn_args(
         });
     }
     deduplicate_arg_names(&mut arg_names);
-    let params = arg_names
-        .into_iter()
-        .zip(arg_types)
-        .map(|(name, ty)| make::param(make::ident_pat(make::name(&name)).into(), make::ty(&ty)));
+    let params = arg_names.into_iter().zip(arg_types).map(|(name, ty)| {
+        make::param(make::ext::simple_ident_pat(make::name(&name)).into(), make::ty(&ty))
+    });
     Some((None, make::param_list(None, params)))
 }