Add symbol index FIXME

Jonas Schievink · Jonas Schievink · commit 6766a6b0e189 · 2020-06-11T12:03:08.000+02:00
diff --git a/crates/ra_ide_db/src/symbol_index.rs b/crates/ra_ide_db/src/symbol_index.rs
@@ -177,6 +177,9 @@ pub fn world_symbols(db: &RootDatabase, query: Query) -> Vec<FileSymbol> {
 }
 
 pub fn crate_symbols(db: &RootDatabase, krate: CrateId, query: Query) -> Vec<FileSymbol> {
+    // FIXME(#4842): This now depends on CrateDefMap, why not build the entire symbol index from
+    // that instead?
+
     let def_map = db.crate_def_map(krate);
     let mut files = Vec::new();
     let mut modules = vec![def_map.root];

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,9 @@ pub fn world_symbols(db: &RootDatabase, query: Query) -> Vec<FileSymbol> {`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`pub fn crate_symbols(db: &RootDatabase, krate: CrateId, query: Query) -> Vec<FileSymbol> {`
	`180`	`+ // FIXME(#4842): This now depends on CrateDefMap, why not build the entire symbol index from`
	`181`	`+ // that instead?`
	`182`	`+`
`180`	`183`	`let def_map = db.crate_def_map(krate);`
`181`	`184`	`let mut files = Vec::new();`
`182`	`185`	`let mut modules = vec![def_map.root];`