Rollup merge of #139141 - mejrs:on_unimpl, r=Noratrieb

Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented

The use on the SliceIndex impl appears unreachable, there is no mention of "vector indices" in any test output and I could not get it to show up in error messages.

Author: jhpratt