Skip to content

Commit 4ee90e9

Browse files
committed
Improve flycheck and build script progress reporting
1 parent da1888a commit 4ee90e9

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

crates/project-model/src/build_dependencies.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,9 @@ impl WorkspaceBuildScripts {
312312
match message {
313313
Message::BuildScriptExecuted(mut message) => {
314314
with_output_for(&message.package_id.repr, &mut |name, data| {
315-
progress(format!("running build-script: {name}"));
315+
progress(format!(
316+
"building compile-time-deps: build script {name} run"
317+
));
316318
let cfgs = {
317319
let mut acc = Vec::new();
318320
for cfg in &message.cfgs {
@@ -343,7 +345,9 @@ impl WorkspaceBuildScripts {
343345
}
344346
Message::CompilerArtifact(message) => {
345347
with_output_for(&message.package_id.repr, &mut |name, data| {
346-
progress(format!("building proc-macros: {name}"));
348+
progress(format!(
349+
"building compile-time-deps: proc-macro {name} built"
350+
));
347351
if message.target.kind.contains(&cargo_metadata::TargetKind::ProcMacro)
348352
{
349353
// Skip rmeta file

crates/rust-analyzer/src/flycheck.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::{fmt, io, process::Command, time::Duration};
66
use cargo_metadata::PackageId;
77
use crossbeam_channel::{Receiver, Sender, select_biased, unbounded};
88
use ide_db::FxHashSet;
9+
use itertools::Itertools;
910
use paths::{AbsPath, AbsPathBuf, Utf8PathBuf};
1011
use rustc_hash::FxHashMap;
1112
use serde::Deserialize as _;
@@ -379,7 +380,11 @@ impl FlycheckActor {
379380
package_id = msg.package_id.repr,
380381
"artifact received"
381382
);
382-
self.report_progress(Progress::DidCheckCrate(msg.target.name));
383+
self.report_progress(Progress::DidCheckCrate(format!(
384+
"{} ({})",
385+
msg.target.name,
386+
msg.target.kind.iter().format_with(", ", |kind, f| f(&kind)),
387+
)));
383388
let package_id = Arc::new(msg.package_id);
384389
if self.diagnostics_cleared_for.insert(package_id.clone()) {
385390
tracing::trace!(

0 commit comments

Comments
 (0)