Merge #9160

bors[bot] · lnicola · web-flow · commit 1d8bd4fdf63e · 2021-06-07T09:59:32.000Z
9160: internal: make `Documentation::new` non-generic r=lnicola a=lnicola



Co-authored-by: Laurențiu Nicola &lt;lnicola@dend.ro&gt;
diff --git a/crates/hir_def/src/attr.rs b/crates/hir_def/src/attr.rs
@@ -36,8 +36,8 @@ use crate::{
 pub struct Documentation(String);
 
 impl Documentation {
-    pub fn new(s: impl Into<String>) -> Self {
-        Documentation(s.into())
+    pub fn new(s: String) -> Self {
+        Documentation(s)
     }
 
     pub fn as_str(&self) -> &str {

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,8 @@ use crate::{`
`36`	`36`	`pub struct Documentation(String);`
`37`	`37`
`38`	`38`	`impl Documentation {`
`39`		`- pub fn new(s: impl Into<String>) -> Self {`
`40`		`- Documentation(s.into())`
	`39`	`+ pub fn new(s: String) -> Self {`
	`40`	`+ Documentation(s)`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`pub fn as_str(&self) -> &str {`