Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Commit cf9802d

Browse files
committed
Fix tests for new TextEdit calculation
1 parent 84ac4ad commit cf9802d

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

rls/src/actions/format.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,13 @@ mod tests {
224224
)
225225
}
226226
// Handle single-line text wrt. added/removed trailing newline
227-
test_case("fn main() {} ", vec![(0, 0, 0, 13, "fn main() {}\n")]);
228-
test_case("fn main() {} \n", vec![(0, 0, 0, 13, "fn main() {}")]);
229-
test_case("\nfn main() {} \n", vec![(0, 0, 1, 13, "fn main() {}")]);
227+
test_case("fn main() {} ", vec![(0, 0, 1, 0, "fn main() {}\n\n")]);
228+
test_case("fn main() {} \n", vec![(0, 0, 1, 0, "fn main() {}\n")]);
229+
test_case("\nfn main() {} \n", vec![(0, 0, 2, 0, "fn main() {}\n")]);
230230
// Check that we send two separate edits
231231
test_case(
232232
" struct Upper ;\n\nstruct Lower ;",
233-
vec![(0, 0, 0, 16, "struct Upper;"), (2, 0, 2, 14, "struct Lower;\n")],
233+
vec![(0, 0, 1, 0, "struct Upper;\n"), (2, 0, 3, 0, "struct Lower;\n\n")],
234234
);
235235
}
236236
}

tests/client.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -935,7 +935,7 @@ fn client_format_utf16_range() {
935935
result.unwrap().iter().map(|edit| edit.new_text.as_str().replace('\r', "")).collect();
936936
// Actual formatting isn't important - what is, is that the buffer isn't
937937
// malformed and code stays semantically equivalent.
938-
assert_eq!(new_text, vec!["/* 😢😢😢😢😢😢😢 */\nfn main() {}\n"]);
938+
assert_eq!(new_text, vec!["/* 😢😢😢😢😢😢😢 */\nfn main() {}\n\n"]);
939939
}
940940

941941
#[test]
@@ -1765,9 +1765,9 @@ fn client_reformat() {
17651765
assert_eq!(result.unwrap()[0], TextEdit {
17661766
range: Range {
17671767
start: Position { line: 0, character: 0 },
1768-
end: Position { line: 1, character: 69 },
1768+
end: Position { line: 2, character: 0 },
17691769
},
1770-
new_text: "pub mod foo;\npub fn main() {\n let world = \"world\";\n println!(\"Hello, {}!\", world);\n}".to_string(),
1770+
new_text: "pub mod foo;\npub fn main() {\n let world = \"world\";\n println!(\"Hello, {}!\", world);\n}\n".to_string(),
17711771
});
17721772
}
17731773

@@ -1804,14 +1804,15 @@ fn client_reformat_with_range() {
18041804
let newline = if cfg!(windows) { "\r\n" } else { "\n" };
18051805
let formatted = r#"pub fn main() {
18061806
let world1 = "world";
1807-
println!("Hello, {}!", world1);"#
1808-
.replace("\r", "")
1809-
.replace("\n", newline);
1807+
println!("Hello, {}!", world1);
1808+
"#
1809+
.replace("\r", "")
1810+
.replace("\n", newline);
18101811

18111812
let edits = result.unwrap();
18121813
assert_eq!(edits.len(), 2);
18131814
assert_eq!(edits[0].new_text, formatted);
1814-
assert_eq!(edits[1].new_text, "");
1815+
assert_eq!(edits[1].new_text, newline);
18151816
}
18161817

18171818
#[test]

0 commit comments

Comments
 (0)